-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Starboard: support --v for verbosity #4583
Starboard: support --v for verbosity #4583
Conversation
@niranjanyardi can you PTAL at the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but do we need to move anything around based on teh conversation in the Chrobalt 3P chat?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apart from the open comment lgtm
c282596
to
7182287
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As is, common_test won't run—it hasn't been added to the gha config code. If that's on purpose because other tests in the suite fail right now, okay, but if the test does currently pass let's run it.
I also think Niranjan is correct that the common_test target should be built with the starboard toolchain instead of the Cobalt toolchain, but that's something we can follow up with
I say let's land this CL/PR, which is about the logging |
Starboard builds and in particular the
nplb
integration test support a command line flag--min_log_level=(info|warning|error|fatal)
. Chromium binaries prefer in general--v
(or
-v
) for this purpose.This CL adds logic to handle
--v
; to preserve previous behaviour, if and when both--min_log_level
and--v
are present, the former takes precedence.This CL also add unit tests for the translation between flag arguments and log level.
First instance of
starboard_unittests
!Bug: 378879686
Bug: 384819454