ui/ozone/starboard: introduce ScopedSbWindow #4590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y4vor
approved these changes
Dec 16, 2024
TyHolc
approved these changes
Dec 16, 2024
TyHolc
added a commit
to TyHolc/cobalt
that referenced
this pull request
Jan 7, 2025
This reverts commit cc55e87.
TyHolc
added a commit
that referenced
this pull request
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #4487, namely:
SbWindow's lifetime (so that destruction doesn't need to happen manually in~GLOzoneEGLStarboard()).SurfaceFactoryStarboardSupportTesttest cases; I usedozone_unitteststo verify the above changes, and the parameterization was just an opaque number.b/371272304