Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up Cobalt build acceleration with RBE #4604

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Set up Cobalt build acceleration with RBE #4604

wants to merge 2 commits into from
+31 −15

Conversation

briantting
Copy link
Contributor

@briantting briantting commented Dec 18, 2024 •
edited
Loading

b/384982606

@briantting briantting changed the title Setup default RBE usage, facilitating CI RBE usage. Set up Chrobalt build acceleration with RBE. Dec 18, 2024
@briantting briantting force-pushed the main branch 2 times, most recently from a320f77 to dd5de54 Compare December 20, 2024 22:41
@briantting briantting force-pushed the main branch 4 times, most recently from 7985666 to 8ae2da3 Compare January 9, 2025 13:44
@briantting briantting marked this pull request as ready for review January 9, 2025 21:06
@briantting briantting requested review from a team as code owners January 9, 2025 21:06
@briantting briantting requested a review from dahlstrom-g January 9, 2025 21:06
@briantting briantting requested a review from kaidokert January 9, 2025 21:09
andrewsavage1
andrewsavage1 reviewed Jan 9, 2025
View reviewed changes
DEPS Outdated Show resolved Hide resolved
buildtools/reclient_cfgs/rewrapper_linux_cc.cfg Outdated Show resolved Hide resolved
build/toolchain/rbe.gni Outdated Show resolved Hide resolved
@briantting briantting force-pushed the main branch 5 times, most recently from 188ea9a to 43c02b2 Compare January 10, 2025 21:58
kaidokert
kaidokert reviewed Jan 13, 2025
View reviewed changes
build/toolchain/rbe.gni Outdated Show resolved Hide resolved
kaidokert
kaidokert reviewed Jan 13, 2025
View reviewed changes
build/toolchain/rbe.gni Outdated Show resolved Hide resolved
kaidokert
kaidokert reviewed Jan 13, 2025
View reviewed changes
Copy link
Member

@kaidokert kaidokert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a pass through - please take a look.

Other than the comments, it looks okay

dahlstrom-g
dahlstrom-g requested changes Jan 13, 2025
View reviewed changes
.github/actions/build/action.yaml Show resolved Hide resolved
cobalt/build/gn.py Outdated Show resolved Hide resolved
@briantting briantting force-pushed the main branch 4 times, most recently from 29c02ca to 9799e1e Compare January 14, 2025 00:48
dahlstrom-g
dahlstrom-g reviewed Jan 14, 2025
View reviewed changes
.github/actions/build/action.yaml Show resolved Hide resolved
.github/actions/build/action.yaml Show resolved Hide resolved
.github/actions/build/action.yaml Show resolved Hide resolved
.github/actions/build/action.yaml Show resolved Hide resolved
dahlstrom-g
dahlstrom-g reviewed Jan 14, 2025
View reviewed changes
Copy link
Contributor

@dahlstrom-g dahlstrom-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote the comment below in my previous reply
but GitHub silently lost it, so I had to write it again.
This has happened to me repeatedly. 😠
GitHub PRs feel inadequate as a review tool.

.github/actions/build/action.yaml Show resolved Hide resolved
cobalt/build/gn.py Outdated Show resolved Hide resolved
kaidokert
kaidokert approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@kaidokert kaidokert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments are all in, LGTM 👍

dahlstrom-g
dahlstrom-g previously approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@dahlstrom-g dahlstrom-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (especially if not squashed)
… are the commits in the right order? 🤷

dahlstrom-g
dahlstrom-g reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

@dahlstrom-g dahlstrom-g left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it stands I believe this PR will break Kokoro builds.

nits:
The word “Chrobalt” should probably be
dropped from the PR and commit titles.
The PR and commit titles shouldn't have periods.
https://cbea.ms/git-commit/#end
Each commit title should be imperative.
https://cbea.ms/git-commit/#imperative

.github/actions/build/action.yaml Outdated Show resolved Hide resolved
@dahlstrom-g dahlstrom-g dismissed their stale review January 15, 2025 18:00

see comments

@briantting briantting changed the title Set up Chrobalt build acceleration with RBE. Set up Cobalt build acceleration with RBE Jan 15, 2025
@briantting
Set up Cobalt build acceleration
057b6e0 
Set up Cobalt build acceleration with RBE making it the default
accelerator for both developers and the CI system.

Remove fetching of RBE cfg files with CIPD. Instead rely on local cfg
files which use public docker images rather than private ones. Taken
from Chromium's trunk.

b/384982606
@briantting
Update action.yaml format and naming
255dd76 
Disables Chromium client side build telemetry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dahlstrom-g dahlstrom-g dahlstrom-g left review comments

@kaidokert kaidokert kaidokert approved these changes

@andrewsavage1 andrewsavage1 Awaiting requested review from andrewsavage1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@briantting @kaidokert @dahlstrom-g @andrewsavage1