Create StarboardBridge native class with jni_generator #4606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haozheng-cobalt
force-pushed
the
jni-1209
branch
from
8a42ed5 to
f73e33b
Compare
haozheng-cobalt
changed the title
haozheng-cobalt
force-pushed
the
jni-1209
branch
from
044a570 to
1dd4f2d
Compare
johnxwork
approved these changes
Dec 19, 2024
xiaomings
reviewed
Dec 30, 2024
| "//starboard/common", | ||
| "//starboard/shared/starboard/media:media_util", | ||
| "//starboard/shared/starboard/player/filter:filter_based_player_sources", | ||
| ] | ||
|
|
||
| deps = [ | ||
| "//base", |
There was a problem hiding this comment.
@andrewsavage1 Just wanted to double check what the guideline is to add dependency from Starboard to a Chromium target (e.g. //base).
There was a problem hiding this comment.
Thanks for bringing this up, as we explicitly disallow //starboard to depend on //base (and most Chromium targets, as the majority of them depend on Starboard). @haozheng-cobalt this should be refactored to take this into account.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/372559388
This PR configures jni_generator for cobalt_apk_java.
It creates the corresponding native class StarboardBridge for cobalt/android/apk/app/src/main/java/dev/cobalt/coat/StarboardBridge.java, adhering to Chromium's JNI standards.
The StarboardBridge native class is implemented as a singleton and is initialized with the same JNIEnv and jobject used when calling the Starboard custom JniEnvExt::Initialize function.
Additionally, it updates the JNI function calls in starboard/android/shared/application_android.cc to align with Chromium's modern JNI standards.
This PR amends the reverted PR #4545
There was an issue in the reverted PR that there are old annotations @UsedByNative embeded in the inner function calls in getResourceOverlay, somehow making the app not able to launch..
Culprit ->
https://github.com/youtube/cobalt/pull/4545/files#diff-22285847addbd15025f71dadd357129f86573e042655067048f94fae301fb1d3R480.
We can not blindly replace @UsedByNative with @CalledByNative, when switching to @CalledByNative, we should make sure to replace all occurrence of @UserByNative inside, and implement the new JNI template functions. I don't get why compiler didn't complain about the getResourceOverlay issue tho.