Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[android] Fix Cobalt crash in official build #4617

Merged
merged 1 commit into from
Jan 3, 2025
Merged

[android] Fix Cobalt crash in official build #4617

merged 1 commit into from
Jan 3, 2025

Conversation

borongc
Copy link
Contributor

@borongc borongc commented Dec 19, 2024 •
edited
Loading

  1. Ensure to initialize RecursiveMutex for SbLog before ApplicationAndroid is initialized.
  2. Enable qa build with official build.

b/384807408

@borongc borongc marked this pull request as draft December 19, 2024 23:18
@borongc borongc force-pushed the fix_cobalt_crash branch 2 times, most recently from e4e3b16 to 85ad205 Compare December 27, 2024 05:38
@borongc borongc changed the title [WIP] Fix Cobalt crash when starting playback [android] Fix Cobalt crash on official build Dec 27, 2024
@borongc borongc changed the title [android] Fix Cobalt crash on official build [android] Fix Cobalt crash in official build Dec 27, 2024
@borongc borongc marked this pull request as ready for review December 27, 2024 05:40
@borongc borongc requested a review from a team as a code owner December 27, 2024 05:40
oxve
oxve approved these changes Dec 27, 2024
View reviewed changes
cobalt/build/gn.py Outdated Show resolved Hide resolved
kaidokert
kaidokert approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@kaidokert kaidokert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd support getting this in ASAP

@borongc
[android] Fix Cobalt crash on official build
cd0e03a 
1. Ensure to initialize RecursiveMutex for SbLog before ApplicationAndroid is initialized.
2. Enable qa build with official build.

b/384807408
@borongc borongc merged commit 8e80e03 into youtube:main Jan 3, 2025
69 of 70 checks passed
@borongc borongc deleted the fix_cobalt_crash branch January 3, 2025 00:12
andrewsavage1 added a commit to andrewsavage1/cobalt that referenced this pull request Jan 13, 2025
@andrewsavage1
Revert "[android] Fix Cobalt crash in official build (youtube#4617)"
a0554c1 
Application is now initialized correctly.

b/389078801

This reverts commit 8e80e03.
andrewsavage1 added a commit that referenced this pull request Jan 14, 2025
@andrewsavage1
Revert "[android] Fix Cobalt crash in official build (#4617)" (#4685)
1637768 
Application is now initialized correctly.

b/389078801

This reverts commit 8e80e03.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsavage1 andrewsavage1 andrewsavage1 approved these changes

@kaidokert kaidokert kaidokert approved these changes

@oxve oxve oxve approved these changes

@johnxwork johnxwork Awaiting requested review from johnxwork

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@borongc @oxve @kaidokert @andrewsavage1