Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define ANDROID_ABI in Cobalt #4622

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Conversation

haozheng-cobalt
Copy link
Contributor

b/385380562

@haozheng-cobalt haozheng-cobalt self-assigned this Dec 20, 2024
@haozheng-cobalt haozheng-cobalt enabled auto-merge (squash) December 20, 2024 22:22
@haozheng-cobalt haozheng-cobalt force-pushed the abi branch 2 times, most recently from 43d5d1f to f08926b Compare December 27, 2024 21:23
@haozheng-cobalt haozheng-cobalt changed the title Define ANDROID_ABI in starboard Define ANDROID_ABI in Cobalt Dec 27, 2024
@haozheng-cobalt haozheng-cobalt enabled auto-merge (squash) December 27, 2024 21:23
cobalt/user_agent/BUILD.gn Show resolved Hide resolved
cobalt/user_agent/BUILD.gn Outdated Show resolved Hide resolved
Copy link
Contributor

@andrewsavage1 andrewsavage1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as you've tested the values are correct for our configurations

cobalt/user_agent/BUILD.gn Show resolved Hide resolved
@haozheng-cobalt haozheng-cobalt merged commit 2d18198 into youtube:main Dec 30, 2024
69 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants