Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check for progressive formats #4624

Merged
merged 4 commits into from
Dec 27, 2024
Merged

Conversation

osagie98
Copy link
Contributor

@osagie98 osagie98 commented Dec 21, 2024

Updates the separator used to parse codecs listed under the "codecs" parameter. Previously, IsProgressiveFormat() would reject content types that had no whitespace between codecs in the "codecs" paramter, but were otherwise valid.

b/382791540

Strips the whitespace in IsProgressiveFormat(). Previously, it would
reject content types that had no whitespace between codecs in the
"codecs" paramter, but were otherwise valid.

b/382791540
Copy link
Contributor

@yell0wd0g yell0wd0g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - does the CanHandleCobaltProgressiveSupportQueries test case need update?

@osagie98 osagie98 enabled auto-merge (squash) December 26, 2024 22:22
@osagie98 osagie98 disabled auto-merge December 26, 2024 22:38
@osagie98 osagie98 enabled auto-merge (squash) December 27, 2024 21:31
@osagie98 osagie98 merged commit 7fce4a7 into youtube:main Dec 27, 2024
71 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants