[android] Enable low end device mode #4625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borongc
requested review from
yell0wd0g,
kaidokert,
johnxwork and
andrewsavage1
|
Is it possible you could run a quick local test and find out how much memory this switch can save us? It will be very helpful in evaluating the impact and tradeoff in the future. |
|
@johnxwork See the comment in the bug. This is about 22.3% reduction on the memory footprint with low-end-device-mode is enabled. |
borongc
force-pushed
the
cobalt_low_end_device
branch
3 times, most recently
from
fcb9a08 to
66693ec
Compare
third_party/blink/renderer/platform/widget/compositing/layer_tree_settings.cc
Outdated
Show resolved
Hide resolved
1. Enable low end device mode to reduce memory usage. 2. Exclude to limit AmountOfPhysicalMemory on low end device mode, which causes the rendering issue. b/380310632
borongc
force-pushed
the
cobalt_low_end_device
branch
from
66693ec to
20b1d41
Compare
borongc
changed the title
johnxwork
approved these changes
Jan 4, 2025
andrewsavage1
approved these changes
Jan 4, 2025
borongc
added a commit
that referenced
this pull request
Jan 7, 2025
RGBA_4444 doesn't work with overlay video mode. - Disable it as it is enabled with low-end-device-mode, #4625. b/380310632
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/380310632