[media] Move concrete SbAudioSink impl to namespace #4634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaomings
force-pushed
the
audio_sink_interface
branch
2 times, most recently
from
03371b8 to
5be7768
Compare
SbAudioSink is a typedef to SbAudioSinkPrivate*, and the concrete implementation of SbAudioSinkPrivate was in the global namespace. Now it's moved into a new class named SbAudioSinkImpl in the namespace starboard::shared::starboard::audio_sink, and it's derived from SbAudioSinkPrivate, which is now an interface. This allows to have multiple SbAudioSink implementations in different namespaces. b/327287075
xiaomings
force-pushed
the
audio_sink_interface
branch
from
5be7768 to
df6dbad
Compare
osagie98
reviewed
Jan 3, 2025
osagie98
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SbAudioSink is a typedef to SbAudioSinkPrivate*, and the concrete implementation of SbAudioSinkPrivate was in the global namespace. Now it's moved into a new class named SbAudioSinkImpl in the namespace starboard::shared::starboard::audio_sink, and it's derived from SbAudioSinkPrivate, which is now an interface.
This allows to have multiple SbAudioSink implementations in different namespaces.
b/327287075