remove circular dependency between //media/base and //media/starboard #4645
Conversation
|
|
||
| #if BUILDFLAG(USE_STARBOARD_MEDIA) | ||
| // TODO(b/326497953): Support Suspend() and Resume(). | ||
| ::media::DecoderBufferAllocator decoder_buffer_allocator_; |
There was a problem hiding this comment.
Sorry for haven't realized that we didn't have our own MediaClient for Cobalt yet. Since @yell0wd0g recommended against modifying //content, we should introduce a Cobalt specific MediaClient.
If there is already a flow setting up for Cobalt initialization, and we just need to create and inject a CobaltMediaClient somewhere, let's do it now. If the initialization flow isn't ready, please file a bug (or find the existing bug) for it, and create a new bug for CobaltMediaClient blocking on the first one.
There was a problem hiding this comment.
Also, we probably don't need to create the decoder_buffer_allocator_ inside a MediaClient for now, and we just need it as a Cobalt wide object somewhere. Feel free to go with that path if there is an obvious place to put such objects. Such a solution should work on both Android TV and Evergreen.
b/380940036
Moves decoder_buffer_allocator_ from //media/base/media_client.h into derived class RenderMediaClient
This supersedes earlier PR #4593