Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up test running and test reporting into separate jobs. #4651

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Split up test running and test reporting into separate jobs.
  • Loading branch information
imindich committed Jan 7, 2025
commit 7bccc71e4bc6fb7023dbf884733bbf75b8dd5b27
11 changes: 1 addition & 10 deletions .github/config/linux.json
Original file line number Diff line number Diff line change
@@ -5,16 +5,7 @@
"linux-x64x11"
],
"targets": [
"base_unittests",
"cobalt:gn_all",
"content_shell",
"gin_unittests",
"gpu_unittests",
"ipc_tests",
"media_unittests",
"mojo_unittests",
"sql_unittests",
"url_unittests"
"gin_unittests"
],
"includes": [
{
41 changes: 30 additions & 11 deletions .github/workflows/main.yaml
Original file line number Diff line number Diff line change
@@ -205,15 +205,34 @@ jobs:
with:
test_artifacts_key: ${{ env.TEST_ARTIFACTS_KEY }}
test_results_key: ${{ env.TEST_RESULTS_KEY }}

test-upload:
needs: [initialize, docker-build-image, build, test]
if: needs.initialize.outputs.test_on_host == 'true' || needs.initialize.outputs.test_on_device == 'true'
permissions: {}
runs-on: [self-hosted, chrobalt-linux-runner]
name: ${{ matrix.name }}_tests_upload
strategy:
fail-fast: false
matrix:
platform: ${{ fromJson(needs.initialize.outputs.platforms) }}
include: ${{ fromJson(needs.initialize.outputs.includes) }}
config: [devel]
container: ${{ needs.docker-build-image.outputs.docker_tag }}
env:
TMPDIR: /__w/_temp
TEST_ARTIFACTS_KEY: ${{ matrix.platform }}_${{ matrix.name }}_test_artifacts
TEST_RESULTS_KEY: ${{ matrix.platform }}_${{ matrix.name }}_test_results
steps:
- name: Process Test Results
if: |
always() &&
(
steps.on-host-tests.outcome == 'success' ||
steps.on-host-tests.outcome == 'failure'
)
uses: ./src/.github/actions/process_test_results
with:
test_results_key: ${{ env.TEST_RESULTS_KEY }}
datadog_api_key: ${{ secrets.datadog_api_key }}
continue-on-error: true
if: |
always() &&
(
steps.on-host-tests.outcome == 'success' ||
steps.on-host-tests.outcome == 'failure'
)
uses: ./src/.github/actions/process_test_results
with:
test_results_key: ${{ env.TEST_RESULTS_KEY }}
datadog_api_key: ${{ secrets.datadog_api_key }}
continue-on-error: true
Loading