[media] Rename SbMediaIs*Supported() functions #4664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaomings
force-pushed
the
mime_util_refactor
branch
from
664a08a to
e38ae20
Compare
xiaomings
force-pushed
the
mime_util_refactor
branch
from
e38ae20 to
ab9e812
Compare
`SbMediaIsAudioSupported()`, `SbMediaIsSupported()`, and `SbMediaIsVideoSupported()` were never part of the Starboard interface. Their Sb prefixes were removed and renamed to `MediaIsAudioSupported()`, `MediaIsSupported()`, and `MediaIsVideoSupported()`. They are also moved from the global namespace into ::starboard::shared::starboard::media. b/327287075
xiaomings
force-pushed
the
mime_util_refactor
branch
from
ab9e812 to
5e6ab8c
Compare
jasonzhangxx
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SbMediaIsAudioSupported(),SbMediaIsSupported(), andSbMediaIsVideoSupported()were never part of the Starboard interface.Their Sb prefixes were removed and renamed to
MediaIsAudioSupported(),MediaIsSupported(), andMediaIsVideoSupported(). They are also moved from the global namespace into ::starboard::shared::starboard::media.There are no functional changes in this PR.
b/327287075