[media] Refine DecoderBufferAllocator memory budget #4674
Merged
+76
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niranjanyardi
approved these changes
Jan 9, 2025
xiaomings
force-pushed
the
decoder_buffer_allocator
branch
from
999579f to
acd1769
Compare
xiaomings
force-pushed
the
decoder_buffer_allocator
branch
from
acd1769 to
8d0214c
Compare
borongc
reviewed
Jan 9, 2025
xiaomings
force-pushed
the
decoder_buffer_allocator
branch
2 times, most recently
from
b5863f1 to
d3802ad
Compare
borongc
reviewed
Jan 9, 2025
xiaomings
force-pushed
the
decoder_buffer_allocator
branch
4 times, most recently
from
7def28c to
9ddf1c6
Compare
jasonzhangxx
approved these changes
Jan 9, 2025
borongc
reviewed
Jan 10, 2025
xiaomings
force-pushed
the
decoder_buffer_allocator
branch
4 times, most recently
from
7fc63cd to
ba5f861
Compare
Now SbMedia budget functions are properly respected when deciding MediaSource buffer memory limits. DecoderBuffer::Allocator interface has been refined to remove SbMedia types, and all Starboard dependency is resolved inside the concrete DecoderBufferAllocator implementation in //media/starboard. The logic to determine whether a video is 10 bits has been refined, as the video mime type is no longer available. b/322027866
xiaomings
force-pushed
the
decoder_buffer_allocator
branch
from
ba5f861 to
1914d23
Compare
borongc
approved these changes
Jan 11, 2025
andrewsavage1
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now SbMedia budget functions are properly respected when deciding MediaSource buffer memory limits.
DecoderBuffer::Allocator interface has been refined to remove SbMedia types, and all Starboard dependency is resolved inside the concrete DecoderBufferAllocator implementation in //media/starboard.
The logic to determine whether a video is 10 bits has been refined, as the video mime type is no longer available.
b/322027866