DIAL service improvement to handle zero size SSDP request. #4680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b/268088112 Change-Id: Icf349616bbf65bbf3408f54a9f5d27b8fdf7bf76
|
In some cases iPhone sends SSDP request with data length 0 or for some reason recvfrom() returns 0. |
MSoliankoLuxoft
approved these changes
Jan 13, 2025
| @@ -126,7 +126,7 @@ void DialUdpServer::AcceptAndProcessConnection() { | |||
| auto err_code = socket_->RecvFrom( | |||
| read_buf_.get(), kReadBufferSize, &client_address_, | |||
| base::Bind(&DialUdpServer::DidRead, base::Unretained(this))); | |||
| if (err_code > 0) { | |||
| if (err_code >= 0) { | |||
There was a problem hiding this comment.
In some cases iPhone sends SSDP request with data length 0 or for some reason recvfrom() returns 0 and DialUdpServer::DidRead() is not called as callback function (line 128). But DialUdpServer::DidRead() must be called to initiate receiving of next request. This update allows to handle requests that have data length equal to 0 and call DialUdpServer::DidRead()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DIAL service improvement to handle zero size SSDP request.
b/268088112
Change-Id: Icf349616bbf65bbf3408f54a9f5d27b8fdf7bf76