JNI migration to jni_generator for file starboard/android/shared/file_internal.cc #4684
+151
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haozheng-cobalt
force-pushed
the
jni-0110
branch
from
23ade15 to
1f8126c
Compare
haozheng-cobalt
force-pushed
the
jni-0110
branch
from
1f8126c to
ff52b2e
Compare
b/389117681
haozheng-cobalt
force-pushed
the
jni-0110
branch
from
ff52b2e to
f541bf0
Compare
haozheng-cobalt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR primarily does JNI migration to jni_generator for file starboard/android/shared/file_internal.cc.
Manually retrieving jclass, jmethodID etc. for android.content.Context because I'm not familiar with how to generate boilerplate code using jni_generator for Android SDK in gn.
This PR also migrates StarboardBridge functions requestSuspend, raisePlatformError, getUserAgentAuxField.
Local testing:
haozheng@haozheng:~/chromium/src$ adb logcat | grep dir:
01-15 13:57:49.181 21743 21743 I starboard: [dev.cobalt.coat/21743:0115/215749.180116(UTC):INFO:file_internal.cc(63)] Files dir: /data/user/0/dev.cobalt.coat/files
01-15 13:57:49.181 21743 21743 I starboard: [dev.cobalt.coat/21743:0115/215749.181740(UTC):INFO:file_internal.cc(69)] Cache dir: /data/user/0/dev.cobalt.coat/cache
01-15 13:57:49.182 21743 21743 I starboard: [dev.cobalt.coat/21743:0115/215749.182423(UTC):INFO:file_internal.cc(76)] Lib dir: /data/app/~~XYAjxFO9qO3w-PB__fJrIw==/dev.cobalt.coat-lopgoPVMucdrTtNnP5MMog==/lib/arm
b/389117681