[Ozone] Move ownership of SbWindow to the platform window class #4688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move ownership of SbWindow to PlatformWindowStarboard, allowing us to get the proper initialization size and assign it as the platform window in the platform window delegate. b/388348504
TyHolc
commented
Jan 13, 2025
| @@ -39,6 +38,8 @@ int main(int argc, const char** argv) { | |||
| "--disable-features=Vulkan", | |||
| // Force some ozone settings. | |||
| "--ozone-platform=starboard", "--use-gl=egl", | |||
| // Set the default size for the content shell/starboard window. | |||
| "--content-shell-host-window-size=1920x1080", | |||
There was a problem hiding this comment.
I chose an arbitrary size here for now, but I was thinking we could create a default SbOptions object and get the height and width from that if we wanted to initialize to those. Lmk thoughts on that.
There was a problem hiding this comment.
(Leaving that Q for @y4vor )
There was a problem hiding this comment.
We should use the existing SbWindowGetSize.
yell0wd0g
approved these changes
Jan 13, 2025
| @@ -39,6 +38,8 @@ int main(int argc, const char** argv) { | |||
| "--disable-features=Vulkan", | |||
| // Force some ozone settings. | |||
| "--ozone-platform=starboard", "--use-gl=egl", | |||
| // Set the default size for the content shell/starboard window. | |||
| "--content-shell-host-window-size=1920x1080", | |||
There was a problem hiding this comment.
(Leaving that Q for @y4vor )
yell0wd0g
approved these changes
Jan 13, 2025
y4vor
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move ownership of SbWindow to PlatformWindowStarboard, allowing us to
get the proper initialization size and assign it as the platform window
in the platform window delegate.
b/388348504