Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add top-level Cobalt WebContentsObserver. #4699

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Add top-level Cobalt WebContentsObserver. #4699

merged 1 commit into from
Jan 15, 2025
+72 −0

Conversation

aee-google
Copy link
Contributor

b/384979128

@aee-google aee-google requested a review from kaidokert January 15, 2025 20:17
@aee-google aee-google enabled auto-merge (squash) January 15, 2025 20:31
kaidokert
kaidokert approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@kaidokert kaidokert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - exactly what was needed, thank you

@kaidokert
Copy link
Member

Test jobs have a bug. I'll override the merge for now

@kaidokert kaidokert disabled auto-merge January 15, 2025 21:17
@kaidokert kaidokert merged commit d08c8cd into youtube:main Jan 15, 2025
87 of 89 checks passed
@aee-google aee-google deleted the web-contents-observer branch January 15, 2025 23:08
@kaidokert kaidokert mentioned this pull request Jan 16, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaidokert kaidokert kaidokert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aee-google @kaidokert