Avoid calling GetMediaTime() on media thread #4703
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetMediaTime() is mostly called on main thread. Instead of calling GetMediaTime() in StarboardRenderer::OnNeedData(), the cl now uses |last_media_time_| and |last_time_media_time_retrieved_| to estimate current media time. As HTMLMediaElement updates media time at least every 250ms, |last_media_time_| and |last_time_media_time_retrieved_| should also be updated at least every 250ms, which should be sufficient to limit audio write ahead. b/376328722
jasonzhangxx
requested review from
sideb0ard,
xiaomings,
osagie98 and
borongc
xiaomings
approved these changes
Jan 16, 2025
| timestamp_of_last_written_audio_ - last_media_time_; | ||
| TimeDelta time_ahead_of_playback; | ||
| { | ||
| base::AutoLock auto_lock(lock_); |
There was a problem hiding this comment.
Now the implementation may write 250ms more audio data when playback is paused. It's probably not an issue, but just bring it up.
| @@ -703,8 +698,15 @@ void StarboardRenderer::OnNeedData(DemuxerStream::Type type, | |||
| adjusted_write_duration_for_preroll) { | |||
| // The estimated time ahead of playback may be negative if no audio has | |||
| // been written. | |||
| TimeDelta time_ahead_of_playback = | |||
| timestamp_of_last_written_audio_ - last_media_time_; | |||
| TimeDelta time_ahead_of_playback; | |||
There was a problem hiding this comment.
The comment above is too far from the calculate and usage of this variable after the change, considering moving it down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetMediaTime() is mostly called on main thread. Instead of calling GetMediaTime() in StarboardRenderer::OnNeedData(), the cl now uses |last_media_time_| and |last_time_media_time_retrieved_| to estimate current media time. As HTMLMediaElement updates media time at least every 250ms, |last_media_time_| and |last_time_media_time_retrieved_| should also be updated at least every 250ms, which should be sufficient to limit audio write ahead.
b/376328722