Animation: Deprecate combo CSS classes in favor of discrete ones. #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously CSS animation classes had to target both the history direction
(forward/back) as well as the animation point (start/end) via a combination
class, even if the properties were shared:
```
.spf-animate-forward-start .spf-animate-new,
.spf-animate-forward-end .spf-animate-old,
.spf-animate-reverse-start .spf-animate-new,
.spf-animate-reverse-end .spf-animate-old {
opacity: 0;
}
```
Now, the classes will be split into discrete ones that represent a single
target only:
`.spf-animate-forward-start -> .spf-animate-forward.spf-animate-start`
`.spf-animate-reverse-end -> .spf-animate-reverse.spf-animate-end`
This allows less verbose CSS when doing animation that does not change based
on history direction.
Progress on youtube#299.
|
LGTM |
nicksay
added a commit
that referenced
this pull request
Feb 23, 2015
Animation: Deprecate combo CSS classes in favor of discrete ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously CSS animation classes had to target both the history direction
(forward/back) as well as the animation point (start/end) via a combination
class, even if the properties were shared:
Now, the classes will be split into discrete ones that represent a single
target only:
.spf-animate-forward-start -> .spf-animate-forward.spf-animate-start.spf-animate-reverse-end -> .spf-animate-reverse.spf-animate-endThis allows less verbose CSS when doing animation that does not change based
on history direction.
Progress on #299.