Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use declare module 'vue' instead of @vue/runtime-core #13067

Merged
merged 1 commit into from
Aug 17, 2024

Conversation

skywalker512
Copy link
Contributor

@skywalker512 skywalker512 commented Aug 15, 2024

vue-router pinia has been replaced.

vuejs/router#2295
vuejs/router@4f082cd

vuejs/pinia@8a6ce86

Sometimes because vant is not replaced, ComponentCustomProperties cannot be used in vue-router and pinia (Only one of these two ways will work) I'm not familiar with Typescript and I don't know why.

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.62%. Comparing base (eef8e0b) to head (31d4840).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13067      +/-   ##
==========================================
- Coverage   89.66%   89.62%   -0.05%     
==========================================
  Files         257      257              
  Lines        6987     6987              
  Branches     1724     1724              
==========================================
- Hits         6265     6262       -3     
- Misses        382      384       +2     
- Partials      340      341       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skywalker512
Copy link
Contributor Author

skywalker512 commented Aug 15, 2024

There is more discussion on this issue. Maybe we should keep it and add declare module 'vue'.

quasarframework/quasar#17416
vuejs/language-tools#4170 (comment)

But after my attempt, it doesn't seem to improve this problem. @vue/runtime-core will always take effect, which will still make vue-router and pinia unavailable.

@skywalker512
Copy link
Contributor Author

more info nuxt/nuxt#28542

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chenjiahan chenjiahan merged commit 2bc831a into youzan:main Aug 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants