Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dialog): add new keyboardEnabled prop #13178

Merged
merged 5 commits into from
Nov 2, 2024

Conversation

lzxiaoqi
Copy link
Contributor

Before submitting a pull request, please read the contributing guide.

在提交 pull request 之前,请阅读 贡献指南

#13164

针对issue #13164 提到的部分手机场景的某些操作会自动执行enter的键盘事件,新增keyboardEnabled属性来控制是否选择使用键盘能力选项

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.63%. Comparing base (379f44a) to head (d4c26dc).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
packages/vant/src/dialog/Dialog.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13178      +/-   ##
==========================================
- Coverage   89.67%   89.63%   -0.04%     
==========================================
  Files         257      257              
  Lines        7004     7006       +2     
  Branches     1732     1733       +1     
==========================================
- Hits         6281     6280       -1     
- Misses        378      382       +4     
+ Partials      345      344       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chenjiahan chenjiahan changed the title feat(dialog): The keyboard capability option is available for support feat(dialog): add new keyboardEnabled prop Nov 2, 2024
@chenjiahan chenjiahan enabled auto-merge (squash) November 2, 2024 04:33
@chenjiahan chenjiahan merged commit 5027d22 into youzan:main Nov 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants