TLE #15
Merged
TLE #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore Neutron Heating TLE when Photon Transport is Enabled
This commit restores Jingang Liang's code for the Photon Heating Tracklength Estimator. Note that there is likely a conflict with TTB and this should be used with LED (electron/positron local energy deposition). This commit does not restore the functionality to generate Photon HDF5 XS with mt=525 Photon KERMA.
-some errant brackets and old? C++ syntax -swapped the order of if statements for the analog estimator and particle==photon
Correct Syntax for Photon Heating TLE
TLE Identifier
Reorganization of logic for Photon TLE; ensuring that photon/electron/positron scoring gets the correct collision heating score.
Comments about re-enabling TLE
Revive energy_fluorescence method. Revive compute_heating method. Compute_heating for IncidentPhoton class
Correct location of compute_heating
Add mt=501, Total photon interaction, to HDF5 Photon Data
Fix scipy quad function. Put function all on one line, (modern Python requirement?)
Extract mt=501 from ACE, Total Photon Interaction XS
Corrections in the workflow for mt501. Added mt301, this is the Average Photon Heating Number [eV/collision]). To be analogous to MCNP mt=301, fm=-6
This is logic that could be used in a formal pull-request, if the TTB double energy counting is not resolved. It it a sort of quick-fix, though preventing photon heating TLE. For now the logic is left out so to allow continued testing with TTB on.
Logic no longer required, as the requisite logic is ready to go in tally_scoring.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge tracklength estimator into latest TLX2