Commits to address review #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Single variable for Survival Normalization
Use single variable wgt0, and multiply cutoffs here (on the fly), rather than having to multply in simulation.cpp. and then telling the physics modules to get this or that cutoff.
Assign Particle Start Weight
Remove lingering cuttoff variables in particle_data.h
Bracket typo in physics.cpp
Not entering final if statement (russian roulette for not survival normalization)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganization of weight parameter multiplication, resulting in a cleaner approach.
Arguably the remaining variable wgt0 in the particle class could be of more use at other times than the immediately multiplied wgt_cutoff, wgt_survive.