Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple sslh systemd unit configurations #231

Closed
wants to merge 7 commits into from

Conversation

Matthewacon
Copy link

@Matthewacon Matthewacon commented May 24, 2019

This change presents a new configuration style for sslh with systemd unit files. Where previously, the global sslh configuration would be in /etc/sslh.cfg, the new configuration layout is /etc/sslh/*.cfg.

For each file located in /etc/sslh/ ending in .cfg, the systemd generator will automatically generate the accompanying socket and drop-in configurations. Individual system service files for each configuration are not required and instead are covered by a single service template [email protected] which takes the name of the desired sslh configuration as a target. The new system follows the structure:

Note: {SYSTEMD_RUN_DIR} is provided to the systemd-sslh-generator binary when invoked by systemd and is thus portable to multiple distributions.

Generator Changes:

  • Added Early systemd generator error logging through /dev/kmsg
  • Fixed memory and file descriptor leaks
  • Added a global systemd service for sslh-select
  • Added systemd-drop-in configurations to prevent the system from running both sslh forking and select units simultaneously, and to associate a configuration's unit with its respective systemd socket configuration

@yrutschle
Copy link
Owner

should there not be some documentation? I feel like most of the text you wrote above should be in a 'systemd.md' file under doc/. Then again, I know nothing about systemd so most of what you wrote went over my head, maybe it's all convention and doesn't need to be explicited.

@stokito
Copy link
Contributor

stokito commented Apr 4, 2024

@yrutschle
Copy link
Owner

I merged the changes in the PR, and I think @stokito your other remarks are all tracked in #419, so I'll close this.
Thanks @Matthewacon for the PR.

@yrutschle yrutschle closed this Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants