[ENH] Add support for self-shielding in heating/cooling rates calculation for RAMSES #4843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cphyc
force-pushed
the
RAMSES-self-shielding
branch
from
1aeb427
to
37490b0
Compare
cphyc
force-pushed
the
RAMSES-self-shielding
branch
from
37490b0
to
fee05ef
Compare
V-Nathir
reviewed
Apr 11, 2024
cphyc
added
code frontends
chrishavlin
reviewed
Apr 11, 2024
|
@yt-fido test this please |
|
Let's hold this a bit more, we probably need testing before this goes in! |
|
okay, converting to draft then ! |
|
Update: this is almost ready to review. I will add a test once #4817 is merged in. |
cphyc
changed the title
cphyc
force-pushed
the
RAMSES-self-shielding
branch
from
8612f0d
to
05c8ff0
Compare
|
The error is due to a missing simulation dataset on Jenkins ( |
|
@yt-fido test this please |
chrishavlin
reviewed
Oct 2, 2024
cphyc
force-pushed
the
RAMSES-self-shielding
branch
2 times, most recently
from
be6cdae
to
6a6813c
Compare
chrishavlin
reviewed
Oct 4, 2024
Hydrogen abundances are defined as (1 - Y) × (1 - Z), where Y is the hard-coded primordial Helium fraction and Z is metallicity. Co-authored-by: Víctor Rufo Pastor <[email protected]>
Co-authored-by: Chris Havlin <[email protected]>
cphyc
force-pushed
the
RAMSES-self-shielding
branch
from
b1e35bd
to
5976261
Compare
chrishavlin
previously approved these changes
Oct 10, 2024
|
@cphyc mind fixing the conflict here once more? then I think we can go ahead and merge this one. |
|
it was actually a trivial merge, so just did it myself :) |
chrishavlin
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
RAMSES uses some self-shiedling to compute the cooling/heating rates.
This parameter is used in
hydro/cooling_fine.f90. When self-shielding is activated, a "boost factor" is computed asboost =exp(-nH/0.01), and the effective density used to look-up the cooling tables is
nH/boost.PR Checklist