-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sph projections, slices, gridding: backend and off-axis #4939
Merged
Merged
Changes from all commits
Commits
Show all changes
64 commits
Select commit
Hold shift + click to select a range
eec9a29
draft 1 off-axis projection and small-particle proj. fix (off-axis ba…
nastasha-w 56c93d3
debugging: axis-aligned SPH projection works again, off-axis runs, bu…
nastasha-w 44d6d46
partway debugging off-axis SPH-proj.
nastasha-w 30d60fa
off-axis projections seem to work
nastasha-w 2ff58cd
first attempt to fix pixelize_sph_kernel_slice
nastasha-w 13cd93a
attempt 1 to fix axis-aligned SPH slices
nastasha-w 9bca940
draft 1 backend SPH cutting plane
nastasha-w 22985f7
passing dataset kernel names to SPH slice/projection backend; work on…
nastasha-w 6a874fe
draft 1 fixed slices, new off-axis slices SPH
nastasha-w 8b3ca65
further bugfix attempts
nastasha-w 31aae23
debugged SPH slices to run; outcome clearly wrong off-axis
nastasha-w 690d64f
partial debug along-axis SPH slices
nastasha-w 695f196
fix complaint from ruff
nastasha-w 80cb90d
debugging: axis-aligned slices pass tests
nastasha-w 1907b2f
fix a ruff complaint
nastasha-w a80228a
on/off-axis SPH slices actually work now
nastasha-w 8e5aca2
hopefully fixed induced grid projection bug;
nastasha-w 9cc98ba
partial debug issues from pull request tests
nastasha-w 429536d
attempted fix bounds issues in off_axis_projection calls (non-SPH ds)
nastasha-w a088d5f
attempted fix: ParticleImageBuffer counts on rotate_particle_coord fu…
nastasha-w effd351
add new pz argument to test_off_axis_SPH pixelize_sph_kernel_projecti…
nastasha-w 33b2c10
attempted fix issue with non-coordinate center arg off_axis_projection
nastasha-w 0d13beb
attempted fix ruff complaint import sorting
nastasha-w 15fcea4
removed unneeded parentheses
nastasha-w 5bb4bd7
SPH scatter gridding fixes, tests passed
nastasha-w 222500e
minor documentation updates
nastasha-w f5c476a
doc updates I forgot to save
nastasha-w 7d8b676
fix ruff comment: not declaring unused h_j3
nastasha-w 170e9af
fix test_offaxis_moment failure
nastasha-w 9b91e4f
fix ruff comment end of file?
nastasha-w 71cc131
draft 1 adding SPH pixelization tests (copied from separate file)
nastasha-w 159167b
fix ruff issues
nastasha-w 2f589c9
order imports correctly?
nastasha-w aecc051
separate out pytest-only tests, add to nose ignore lists
nastasha-w fa78f5c
remove trailing whitespace
nastasha-w 785108a
add typing option of (array, unit) values
nastasha-w fec520f
attempted change typing to work with python 3.9
nastasha-w f4dd2cc
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] d4e5bfb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] b4f4935
attempting to pass type-checking
nastasha-w ebb357c
ruff fix
nastasha-w f09851c
more attempted type check fixes
nastasha-w 987e50e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 422e716
more attempted type-checking fixes
nastasha-w 02011d0
avoid test failures from divide by zero errors
nastasha-w be087ce
BUG: fix a defect in CartesianCoordinateHandler._ortho_pixelize
neutrinoceros 374a758
BUG: fix a defect in OffAxisProjectionFixedResolutionBuffer._generate…
neutrinoceros e8a0371
ruff fix
nastasha-w 7f129c1
avoid 'divide by zero' errors
nastasha-w 6f57981
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 45574d6
fix .v on numpy array problem
nastasha-w c653a4f
remove printing in tests ('clogs up' test logs)
nastasha-w 92a7127
attempted fix test error from sqrt(< 0)
nastasha-w 5587ff3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] d3bd38a
docstring typo fix
nastasha-w 726bdf3
pass depth kwarg to off_axis_projection in FITSOffAxisProjection
nastasha-w 8ea95e3
now passing dataset kernel name to SPH gridding backend
nastasha-w 22cac2b
remove hsml margin in line of sight direction for SPH projections
nastasha-w 5362365
add prefixes marking old and new test images
nastasha-w 0580c69
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] d000cd5
increase numbers for frontend tests affect by SPH backend change
nastasha-w f466494
comments update
nastasha-w f8949c2
actually update gizmo, owls test numbers
nastasha-w ac30d15
bumpy arepo test number: avoid missing files error?
nastasha-w File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
self.ds.periodicity
a list? I don't understand the removal ofany()
here. If it's a list, this will always be truthy.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the backend so it can accept either a single boolean or a list/array/whatever of length 3. That allows consistent handling of simulations that are periodic in some, but not all, coordinate directions. I handle those options in these lines in
pixelize_sph_kernel_arbitrary_grid
, file:yt/utilities/lib/pixelization_routines.pyx
. Basically, it allows backwards compatibility for single-value bool inputs in the backend, but it isn't usingif check_period
or something like that.