Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly disallow imageio 2.35.0 in testing deps #4968

Merged
merged 1 commit into from
Aug 17, 2024

Conversation

chrishavlin
Copy link
Contributor

@chrishavlin chrishavlin commented Aug 16, 2024

probable fix for #4966

@chrishavlin chrishavlin added bug dependencies Pull requests that update a dependency file labels Aug 16, 2024
@chrishavlin chrishavlin linked an issue Aug 16, 2024 that may be closed by this pull request
@chrishavlin chrishavlin added the tests: running tests Issues with the test setup label Aug 16, 2024
@chrishavlin
Copy link
Contributor Author

note that imageio has automated weekly releases, so this should resolve itself on Monday after imageio releases again (see imageio/imageio#1097). So unless the failures are holding up merging in the next 2-3 days, it'd be fine to not merge this PR and things should go back to normal on Monday.

@jzuhone
Copy link
Contributor

jzuhone commented Aug 16, 2024

@neutrinoceros sorry, fat finger--didn't mean to request your review here.

@jzuhone jzuhone self-requested a review August 16, 2024 19:36
@neutrinoceros
Copy link
Member

I doesn't hurt to merge it now. Thanks all !

@neutrinoceros neutrinoceros merged commit 981a8be into yt-project:main Aug 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dependencies Pull requests that update a dependency file tests: running tests Issues with the test setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failing enzo answer tests
3 participants