TST: add image tests for cylindrical pixelization of a box with rmin>0 #5036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
force-pushed
the
viz/tst/image_test_cyclindrical_pix
branch
from
43826f5 to
5498ef6
Compare
neutrinoceros
commented
Oct 31, 2024
Comment on lines
+439
to
+441
| *, | ||
| domain_left_edge=None, | ||
| domain_right_edge=None, |
There was a problem hiding this comment.
I needed to expose these parameters because we didn't have a fake_ds function that exposed both domain limits and geometry, which explains why the cases I'm interested in here are not covered yet.
There was a problem hiding this comment.
this is generally useful beyond this PR too. in the past i've run into this and ended up using load_uniform_grid, but it's nice to have it built in to fake_amr_ds!
neutrinoceros
force-pushed
the
viz/tst/image_test_cyclindrical_pix
branch
from
f6c09b3 to
cce334e
Compare
This was referenced Oct 31, 2024
neutrinoceros
force-pushed
the
viz/tst/image_test_cyclindrical_pix
branch
from
684b8c2 to
5080983
Compare
chrishavlin
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
In support of #5035 after identifying such cases as blind spots in the test suite.
update: companion PR