Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat empty format selection string as "anything goes". #32786

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mk-pmb
Copy link
Contributor

@mk-pmb mk-pmb commented May 16, 2024

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Empty format selection string always leads to ExtractorError: requested format not available, even if there clearly are some. If the user has no criteria at all, i.e. anything goes, then worst obviously is good enough for them, but a lie is not.

I had considered giving them best, but for users who really don't care about media quality, we should optimize for low power consumption in all affected equipment.

@mk-pmb mk-pmb force-pushed the empty-format-selection-means-anything-goes branch from ea2bcbb to ce031e9 Compare May 16, 2024 00:54
@dirkf
Copy link
Contributor

dirkf commented May 24, 2024

But there's a default if the option isn't mentioned.

Is this an API issue?

@mk-pmb
Copy link
Contributor Author

mk-pmb commented May 25, 2024

Yes, it is an API issue. What I really wanted to do was submit another test case, but to express that other test case in a simple way, I need this patch here first. Otherwise I'd have to include a workaround for this issue here and explain the seeming lie.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants