Skip to content

Commit

Permalink
Reporting a separate issue for all the different unsupported datatype…
Browse files Browse the repository at this point in the history 
…s for the issue index on complex datatypes in schema report and assessment report (#2288)

- Earlier indexes on all the complex datatypes were reported under a single issue type: INDEX ON COMPLEX DATATYPES
- Added a separate issue for all such complex datatypes and removed the original issue.
- Reporting the issue in both the analyze schema report and the assessment report.
- Fixed issue: Define separate Issue for each case related to datatype(unsupported datatype, index on complex datatype) #2231
  • Loading branch information
@ShivanshGahlot
ShivanshGahlot authored Feb 25, 2025
1 parent 0c48c76 commit ec1cb4f
Show file tree
Hide file tree
Showing 10 changed files with 1,403 additions and 414 deletions.
596 changes: 298 additions & 298 deletions migtests/tests/analyze-schema/expected_issues.json
View file

Large diffs are not rendered by default.

98 changes: 49 additions & 49 deletions migtests/tests/pg/assessment-report-test/expectedAssessmentReport.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -453,9 +453,9 @@
{
"Category": "unsupported_features",
"CategoryDescription": "Features of the source database that are not supported on the target YugabyteDB.",
"Type": "INDEX_ON_COMPLEX_DATATYPE",
"Name": "Index on column with complex datatype",
"Description": "Indexes on columns with complex data types like 'citext' are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Type": "INDEX_ON_CITEXT_DATATYPE",
"Name": "Index on column with citext datatype",
"Description": "Indexes on columns with citext data type are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Impact": "LEVEL_1",
"ObjectType": "INDEX",
"ObjectName": "idx_citext ON public.citext_type",
Expand All @@ -466,9 +466,9 @@
{
"Category": "unsupported_features",
"CategoryDescription": "Features of the source database that are not supported on the target YugabyteDB.",
"Type": "INDEX_ON_COMPLEX_DATATYPE",
"Name": "Index on column with complex datatype",
"Description": "Indexes on columns with complex data types like 'tsvector' are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Type": "INDEX_ON_TSVECTOR_DATATYPE",
"Name": "Index on column with tsvector datatype",
"Description": "Indexes on columns with tsvector data type are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Impact": "LEVEL_1",
"ObjectType": "INDEX",
"ObjectName": "tsvector_idx ON public.documents",
Expand All @@ -479,9 +479,9 @@
{
"Category": "unsupported_features",
"CategoryDescription": "Features of the source database that are not supported on the target YugabyteDB.",
"Type": "INDEX_ON_COMPLEX_DATATYPE",
"Name": "Index on column with complex datatype",
"Description": "Indexes on columns with complex data types like 'tsquery' are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Type": "INDEX_ON_TSQUERY_DATATYPE",
"Name": "Index on column with tsquery datatype",
"Description": "Indexes on columns with tsquery data type are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Impact": "LEVEL_1",
"ObjectType": "INDEX",
"ObjectName": "tsquery_idx ON public.ts_query_table",
Expand All @@ -492,9 +492,9 @@
{
"Category": "unsupported_features",
"CategoryDescription": "Features of the source database that are not supported on the target YugabyteDB.",
"Type": "INDEX_ON_COMPLEX_DATATYPE",
"Name": "Index on column with complex datatype",
"Description": "Indexes on columns with complex data types like 'jsonb' are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Type": "INDEX_ON_JSONB_DATATYPE",
"Name": "Index on column with jsonb datatype",
"Description": "Indexes on columns with jsonb data type are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Impact": "LEVEL_1",
"ObjectType": "INDEX",
"ObjectName": "idx_json ON public.test_jsonb",
Expand All @@ -505,9 +505,9 @@
{
"Category": "unsupported_features",
"CategoryDescription": "Features of the source database that are not supported on the target YugabyteDB.",
"Type": "INDEX_ON_COMPLEX_DATATYPE",
"Name": "Index on column with complex datatype",
"Description": "Indexes on columns with complex data types like 'jsonb' are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Type": "INDEX_ON_JSONB_DATATYPE",
"Name": "Index on column with jsonb datatype",
"Description": "Indexes on columns with jsonb data type are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Impact": "LEVEL_1",
"ObjectType": "INDEX",
"ObjectName": "idx_json2 ON public.test_jsonb",
Expand All @@ -518,9 +518,9 @@
{
"Category": "unsupported_features",
"CategoryDescription": "Features of the source database that are not supported on the target YugabyteDB.",
"Type": "INDEX_ON_COMPLEX_DATATYPE",
"Name": "Index on column with complex datatype",
"Description": "Indexes on columns with complex data types like 'inet' are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Type": "INDEX_ON_INET_DATATYPE",
"Name": "Index on column with inet datatype",
"Description": "Indexes on columns with inet data type are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Impact": "LEVEL_1",
"ObjectType": "INDEX",
"ObjectName": "idx_inet ON public.inet_type",
Expand All @@ -531,9 +531,9 @@
{
"Category": "unsupported_features",
"CategoryDescription": "Features of the source database that are not supported on the target YugabyteDB.",
"Type": "INDEX_ON_COMPLEX_DATATYPE",
"Name": "Index on column with complex datatype",
"Description": "Indexes on columns with complex data types like 'macaddr' are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Type": "INDEX_ON_MACADDR_DATATYPE",
"Name": "Index on column with macaddr datatype",
"Description": "Indexes on columns with macaddr data type are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Impact": "LEVEL_1",
"ObjectType": "INDEX",
"ObjectName": "idx2 ON public.combined_tbl",
Expand All @@ -544,9 +544,9 @@
{
"Category": "unsupported_features",
"CategoryDescription": "Features of the source database that are not supported on the target YugabyteDB.",
"Type": "INDEX_ON_COMPLEX_DATATYPE",
"Name": "Index on column with complex datatype",
"Description": "Indexes on columns with complex data types like 'macaddr8' are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Type": "INDEX_ON_MACADDR8_DATATYPE",
"Name": "Index on column with macaddr8 datatype",
"Description": "Indexes on columns with macaddr8 data type are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Impact": "LEVEL_1",
"ObjectType": "INDEX",
"ObjectName": "idx3 ON public.combined_tbl",
Expand All @@ -557,9 +557,9 @@
{
"Category": "unsupported_features",
"CategoryDescription": "Features of the source database that are not supported on the target YugabyteDB.",
"Type": "INDEX_ON_COMPLEX_DATATYPE",
"Name": "Index on column with complex datatype",
"Description": "Indexes on columns with complex data types like 'cidr' are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Type": "INDEX_ON_CIDR_DATATYPE",
"Name": "Index on column with cidr datatype",
"Description": "Indexes on columns with cidr data type are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Impact": "LEVEL_1",
"ObjectType": "INDEX",
"ObjectName": "idx1 ON public.combined_tbl",
Expand All @@ -570,9 +570,9 @@
{
"Category": "unsupported_features",
"CategoryDescription": "Features of the source database that are not supported on the target YugabyteDB.",
"Type": "INDEX_ON_COMPLEX_DATATYPE",
"Name": "Index on column with complex datatype",
"Description": "Indexes on columns with complex data types like 'bit' are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Type": "INDEX_ON_BIT_DATATYPE",
"Name": "Index on column with bit datatype",
"Description": "Indexes on columns with bit data type are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Impact": "LEVEL_1",
"ObjectType": "INDEX",
"ObjectName": "idx5 ON public.combined_tbl",
Expand All @@ -583,9 +583,9 @@
{
"Category": "unsupported_features",
"CategoryDescription": "Features of the source database that are not supported on the target YugabyteDB.",
"Type": "INDEX_ON_COMPLEX_DATATYPE",
"Name": "Index on column with complex datatype",
"Description": "Indexes on columns with complex data types like 'varbit' are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Type": "INDEX_ON_VARBIT_DATATYPE",
"Name": "Index on column with varbit datatype",
"Description": "Indexes on columns with varbit data type are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Impact": "LEVEL_1",
"ObjectType": "INDEX",
"ObjectName": "idx6 ON public.combined_tbl",
Expand All @@ -596,9 +596,9 @@
{
"Category": "unsupported_features",
"CategoryDescription": "Features of the source database that are not supported on the target YugabyteDB.",
"Type": "INDEX_ON_COMPLEX_DATATYPE",
"Name": "Index on column with complex datatype",
"Description": "Indexes on columns with complex data types like 'daterange' are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Type": "INDEX_ON_DATERANGE_DATATYPE",
"Name": "Index on column with daterange datatype",
"Description": "Indexes on columns with daterange data type are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Impact": "LEVEL_1",
"ObjectType": "INDEX",
"ObjectName": "idx8 ON public.combined_tbl",
Expand All @@ -609,9 +609,9 @@
{
"Category": "unsupported_features",
"CategoryDescription": "Features of the source database that are not supported on the target YugabyteDB.",
"Type": "INDEX_ON_COMPLEX_DATATYPE",
"Name": "Index on column with complex datatype",
"Description": "Indexes on columns with complex data types like 'interval' are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Type": "INDEX_ON_INTERVAL_DATATYPE",
"Name": "Index on column with interval datatype",
"Description": "Indexes on columns with interval data type are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Impact": "LEVEL_1",
"ObjectType": "INDEX",
"ObjectName": "idx9 ON public.combined_tbl",
Expand All @@ -622,9 +622,9 @@
{
"Category": "unsupported_features",
"CategoryDescription": "Features of the source database that are not supported on the target YugabyteDB.",
"Type": "INDEX_ON_COMPLEX_DATATYPE",
"Name": "Index on column with complex datatype",
"Description": "Indexes on columns with complex data types like 'pg_lsn' are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Type": "INDEX_ON_PG_LSN_DATATYPE",
"Name": "Index on column with pg_lsn datatype",
"Description": "Indexes on columns with pg_lsn data type are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Impact": "LEVEL_1",
"ObjectType": "INDEX",
"ObjectName": "idx4 ON public.combined_tbl",
Expand All @@ -635,9 +635,9 @@
{
"Category": "unsupported_features",
"CategoryDescription": "Features of the source database that are not supported on the target YugabyteDB.",
"Type": "INDEX_ON_COMPLEX_DATATYPE",
"Name": "Index on column with complex datatype",
"Description": "Indexes on columns with complex data types like 'array' are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Type": "INDEX_ON_ARRAY_DATATYPE",
"Name": "Index on column with array datatype",
"Description": "Indexes on columns with array data type are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Impact": "LEVEL_1",
"ObjectType": "INDEX",
"ObjectName": "idx_array ON public.documents",
Expand All @@ -648,9 +648,9 @@
{
"Category": "unsupported_features",
"CategoryDescription": "Features of the source database that are not supported on the target YugabyteDB.",
"Type": "INDEX_ON_COMPLEX_DATATYPE",
"Name": "Index on column with complex datatype",
"Description": "Indexes on columns with complex data types like 'user_defined_type' are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Type": "INDEX_ON_USER_DEFINED_DATATYPE",
"Name": "Index on column with user defined datatype",
"Description": "Indexes on columns with user defined data types are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Impact": "LEVEL_1",
"ObjectType": "INDEX",
"ObjectName": "idx7 ON public.combined_tbl",
Expand Down Expand Up @@ -4793,4 +4793,4 @@
"<a class=\"highlight-link\" target=\"_blank\" href=\"https://docs.yugabyte.com/preview/yugabyte-voyager/known-issues/#assessment-and-schema-analysis-limitations\">Limitations in assessment</a>",
"There are some Unlogged tables in the schema. They will be created as regular LOGGED tables in YugabyteDB as unlogged tables are not supported."
]
}
}
6 changes: 3 additions & 3 deletions migtests/tests/pg/omnibus/expected_files/expectedAssessmentReport.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -655,9 +655,9 @@
{
"Category": "unsupported_features",
"CategoryDescription": "Features of the source database that are not supported on the target YugabyteDB.",
"Type": "INDEX_ON_COMPLEX_DATATYPE",
"Name": "Index on column with complex datatype",
"Description": "Indexes on columns with complex data types like 'user_defined_type' are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Type": "INDEX_ON_USER_DEFINED_DATATYPE",
"Name": "Index on column with user defined datatype",
"Description": "Indexes on columns with user defined data types are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Impact": "LEVEL_1",
"ObjectType": "INDEX",
"ObjectName": "idx_1 ON composite_type_examples.ordinary_table",
Expand Down
2 changes: 1 addition & 1 deletion migtests/tests/pg/omnibus/expected_files/expected_schema_analysis_report.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@
"IssueType": "unsupported_features",
"ObjectType": "INDEX",
"ObjectName": "idx_1 ON composite_type_examples.ordinary_table",
"Reason": "Indexes on columns with complex data types like 'user_defined_type' are not yet supported in YugabyteDB.",
"Reason": "Indexes on columns with user defined data types are not yet supported in YugabyteDB.",
"SqlStatement": "CREATE INDEX idx_1 ON composite_type_examples.ordinary_table USING btree (basic_);",
"FilePath": "/home/ubuntu/yb-voyager/migtests/tests/pg/omnibus/export-dir/schema/tables/INDEXES_table.sql",
"Suggestion": "Refer to the docs link for the workaround",
Expand Down
Loading

0 comments on commit ec1cb4f

Please sign in to comment.