[DB-15227] Populate the datatype in the UNSUPPORTED_DATATYPE_LIVE_MIGRATION / FF_FB fields in Assessment Issues #2298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RATION / FF_FB fields in Assessment Issues - this might be a temporary fix until we breakdown unsupported datatype issues
sanyamsinghal
requested review from
makalaaneesh,
priyanshi-yb and
shubham-yb
makalaaneesh
approved these changes
Feb 6, 2025
priyanshi-yb
reviewed
Feb 6, 2025
| if type == "object" and | ||
| .Category == "migration_caveats" and | ||
| (.Type == "UNSUPPORTED_DATATYPE_LIVE_MIGRATION" or .Type == "UNSUPPORTED_DATATYPE_LIVE_MIGRATION_WITH_FF_FB") | ||
| then .ObjectName = "IGNORED" |
There was a problem hiding this comment.
Why is it required to ignore the object name for these Type?
There was a problem hiding this comment.
I think just a temporary ignore until we fix it properly :)
There was a problem hiding this comment.
yes, plan is to have individual issue for each datatype.
Updating the test for this temporary fix will be a big change, a lot of test has the corresponding issues including osm, omnibus
priyanshi-yb
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in this pull request
Hence, didn't update the expected values in test, rather ignoring the ObjectName for
category=migration_caveats AND type=UNSUPPORTED_DATATYPE_LIVE_MIGRATION OR UNSUPPORTED_DATATYPE_LIVE_MIGRATION_WITH_FF_FBFixes - https://yugabyte.atlassian.net/browse/DB-15227
Describe if there are any user-facing changes
How was this pull request tested?
Existing tests are enough
Does your PR have changes that can cause upgrade issues?