colocated aware random picker #2301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makalaaneesh
changed the title
Base automatically changed from
aneesh/reuse-worker-pool-sequential-task-picker
to
main
February 11, 2025 17:38
priyanshi-yb
approved these changes
Feb 18, 2025
| if err != nil { | ||
| break | ||
| } | ||
| if task != pickedTask2 && task != pickedTask1 { |
There was a problem hiding this comment.
how can the picked Task be equal to pickedTask1, it is already marked as done above right?
There was a problem hiding this comment.
You're right, it can't. Just wanted to exclude both task1 task2, to get task3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in this pull request
Introduce a ColocatedAwareRandomTaskPicker which picks tasks based on weights/probabilities of the tables involved. This will essentially lead to multiple tables being ingested at the same time.
The max no. of tasks in parallel will be equal to the value of parallel-jobs (either default calculation of 0.25x cores in the case of adaptive parallelism, or the value provided by the user).
Describe if there are any user-facing changes
How was this pull request tested?
Does your PR have changes that can cause upgrade issues?