Do not check for enabled triggers / FKs for fallback workflow of PG if session_replication_role session variable is used #2322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f session_replication_role session variable is used
…rgetConf stored and session vars are already available
priyanshi-yb
requested review from
makalaaneesh,
sanyamsinghal and
ShivanshGahlot
yb-voyager/src/tgtdb/postgres.go
Outdated
| @@ -115,6 +116,9 @@ func (pg *TargetPostgreSQL) Init() error { | |||
| if err != nil { | |||
| return err | |||
| } | |||
| if len(pg.tconf.SessionVars) == 0 { | |||
| pg.tconf.SessionVars = getYBSessionInitScript(pg.tconf) | |||
There was a problem hiding this comment.
We should probably use a different function/vars for this. PG and YB will have different set of session params? The function also does some YB specific stuff - for example checking in /etc/yb-voyager/ybSessionVariables.sql
There was a problem hiding this comment.
So other than the yb-enable-upsert session variable (which is run based on tconf.EnableUpsert), all are common for PG/YB so didn't feel the need right now but yeah we can have separate ones.
shaharuk-yb
pushed a commit
that referenced
this pull request
Feb 27, 2025
…f session_replication_role session variable is used (#2322) Adding GRANT SQL for granting the SET on session_replication_role to source-db-user to utilize it in Fallback case for import data to source Added a check in GetEnabledTriggersAndFks(), to not fetch the triggers/Fks in case this session parameter is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in this pull request
session_replication_roleto source-db-user to utilize it in Fallback case forimport data to sourceDescribe if there are any user-facing changes
Yes, new grant is added in script and guardrail check is fixed for handling the case where
session_replication_roleis used.How was this pull request tested?
Manually
Does your PR have changes that can cause upgrade issues?