Checking mysql-community-devel package instead of mysql-devel package in the airgapped installation script when the OS is RHEL9 #2332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the airgapped installation script when the OS is RHEL9
ShivanshGahlot
requested review from
makalaaneesh,
sanyamsinghal,
shubham-yb and
priyanshi-yb
shubham-yb
reviewed
Feb 18, 2025
Comment on lines
623
to
627
| if [ "$majorVersion" -eq 9 ]; then | ||
| if [[ "$package" == "mysql-devel" ]]; then | ||
| package="mysql-community-devel" | ||
| fi | ||
| fi |
There was a problem hiding this comment.
Maybe we can simplify:
if [[ "$majorVersion" == "9" && "$package" == "mysql-devel" ]]; then
package="mysql-community-devel"
fi
shubham-yb
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is it needed?
The mysql-devel package is not available in RHEL9. Therefore, we need to install mysql-community-devel instead. Because of this reason, in case of RHEL9 airgapped installation we need to check whether the mysql-community-devel package is installed or not instead of the mysql-devel package.
Describe the changes in this pull request
Describe if there are any user-facing changes
No
How was this pull request tested?
Manually
Does your PR have changes that can cause upgrade issues?