Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate query issues for unsupported datatypes and PK/UK on complex datatypes #2361

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
+1,939 −475
Open

Separate query issues for unsupported datatypes and PK/UK on complex datatypes #2361

Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
9ff632f
Reporting individual issues for pg unuspported datatypes using queryi…
ShivanshGahlot Feb 25, 2025
c94ec0d
Reporting individual issues for pg unuspported datatypes for live mig…
ShivanshGahlot Feb 25, 2025
62db777
Reporting individual issues for pg unuspported datatypes for live mig…
ShivanshGahlot Feb 25, 2025
029f1a7
Fixing tests
ShivanshGahlot Feb 26, 2025
3eddd68
Fixing tests
ShivanshGahlot Feb 26, 2025
b8aed40
Fixing tests
ShivanshGahlot Feb 26, 2025
cf1198b
Fixed assessment test using string.EqualFold instead of Contains to f…
ShivanshGahlot Feb 26, 2025
ec4a024
Fixing analyze schema tests
ShivanshGahlot Feb 26, 2025
209c791
Fixing analyze schema tests
ShivanshGahlot Feb 26, 2025
901690e
Created separate issues for all the complex datatypes with PK or UK
ShivanshGahlot Mar 4, 2025
ded3ff6
Removed comments and debugging lines
ShivanshGahlot Mar 4, 2025
ac1c661
Fixing tests
ShivanshGahlot Mar 4, 2025
377c8cc
Fixing tests
ShivanshGahlot Mar 4, 2025
44b4ef6
Fixing HTML report tests
ShivanshGahlot Mar 5, 2025
9569092
Adding tests for PK adn UK on complex in issues ddl tests
ShivanshGahlot Mar 5, 2025
d397165
Adding tests for PK adn UK on complex in issues ddl tests
ShivanshGahlot Mar 5, 2025
c5f0a60
Adding tests for PK adn UK on complex in issues ddl tests
ShivanshGahlot Mar 6, 2025
67fd55b
Added suggested changes
ShivanshGahlot Mar 7, 2025
97f0471
Added suggested changes
ShivanshGahlot Mar 7, 2025
ff207af
Made suggested changes
ShivanshGahlot Mar 10, 2025
49a61f8
Made suggested changes
ShivanshGahlot Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified migtests/tests/analyze-schema/dummy-export-dir/metainfo/meta.db
View file
Open in desktop
Binary file not shown.
70 changes: 35 additions & 35 deletions migtests/tests/analyze-schema/expected_issues.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions migtests/tests/analyze-schema/validate
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ def validate_report_issues(report, expected_issues):
for expected_issue in expected_issues:
assert expected_issue in report["Issues"], f"expected issue is not reported: {expected_issue}"

print ("Length of expected issues:", len(expected_issues))
print ("Length of reported issues:", len(report["Issues"]))
assert len(expected_issues) == len(report["Issues"])
print("Success!")

Expand Down
18 changes: 9 additions & 9 deletions migtests/tests/pg/assessment-report-test/expectedAssessmentReport.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4449,7 +4449,7 @@ <h2>Assessment Issues</h2>

<tbody class="issue-summary-detail-pair"
data-category="unsupported_features"
data-name="Primary/Unique key on column with complex datatype"
data-name="Primary/Unique key on column with varbit datatype"
data-impact="LEVEL_1">
<!-- Summary Row -->
<tr class="summary-row" onclick="toggleDetails('details-33', 'arrow-33')">
Expand All @@ -4458,7 +4458,7 @@ <h2>Assessment Issues</h2>
&nbsp;&nbsp;
Unsupported Features
</td>
<td>Primary/Unique key on column with complex datatype</td>
<td>Primary/Unique key on column with varbit datatype</td>
<td>

public.combined_tbl, constraint: (combined_tbl_bittv_key)
Expand Down Expand Up @@ -4534,7 +4534,7 @@ <h2>Assessment Issues</h2>
<td>

<div style="max-height:150px; overflow-y:auto; border:1px solid #ccc;">
<pre style="white-space: pre-wrap; margin:0;">Primary key and Unique constraints on columns with complex data types like 'varbit' are not yet supported in YugabyteDB. Refer to the docs link for the workaround</pre>
<pre style="white-space: pre-wrap; margin:0;">Primary key and Unique constraints on columns with varbit data type are not yet supported in YugabyteDB. Refer to the docs link for the workaround</pre>
</div>

</td>
Expand All @@ -4548,7 +4548,7 @@ <h2>Assessment Issues</h2>

<tbody class="issue-summary-detail-pair"
data-category="unsupported_features"
data-name="Primary/Unique key on column with complex datatype"
data-name="Primary/Unique key on column with array datatype"
data-impact="LEVEL_1">
<!-- Summary Row -->
<tr class="summary-row" onclick="toggleDetails('details-34', 'arrow-34')">
Expand All @@ -4557,7 +4557,7 @@ <h2>Assessment Issues</h2>
&nbsp;&nbsp;
Unsupported Features
</td>
<td>Primary/Unique key on column with complex datatype</td>
<td>Primary/Unique key on column with array datatype</td>
<td>

public.combined_tbl, constraint: (combined_tbl_pkey)
Expand Down Expand Up @@ -4633,7 +4633,7 @@ <h2>Assessment Issues</h2>
<td>

<div style="max-height:150px; overflow-y:auto; border:1px solid #ccc;">
<pre style="white-space: pre-wrap; margin:0;">Primary key and Unique constraints on columns with complex data types like 'array' are not yet supported in YugabyteDB. Refer to the docs link for the workaround</pre>
<pre style="white-space: pre-wrap; margin:0;">Primary key and Unique constraints on columns with array data type are not yet supported in YugabyteDB. Refer to the docs link for the workaround</pre>
</div>

</td>
Expand All @@ -4647,7 +4647,7 @@ <h2>Assessment Issues</h2>

<tbody class="issue-summary-detail-pair"
data-category="unsupported_features"
data-name="Primary/Unique key on column with complex datatype"
data-name="Primary/Unique key on column with pg_lsn datatype"
data-impact="LEVEL_1">
<!-- Summary Row -->
<tr class="summary-row" onclick="toggleDetails('details-35', 'arrow-35')">
Expand All @@ -4656,7 +4656,7 @@ <h2>Assessment Issues</h2>
&nbsp;&nbsp;
Unsupported Features
</td>
<td>Primary/Unique key on column with complex datatype</td>
<td>Primary/Unique key on column with pg_lsn datatype</td>
<td>

public.combined_tbl, constraint: (uk)
Expand Down Expand Up @@ -4732,7 +4732,7 @@ <h2>Assessment Issues</h2>
<td>

<div style="max-height:150px; overflow-y:auto; border:1px solid #ccc;">
<pre style="white-space: pre-wrap; margin:0;">Primary key and Unique constraints on columns with complex data types like 'pg_lsn' are not yet supported in YugabyteDB. Refer to the docs link for the workaround</pre>
<pre style="white-space: pre-wrap; margin:0;">Primary key and Unique constraints on columns with pg_lsn data type are not yet supported in YugabyteDB. Refer to the docs link for the workaround</pre>
</div>

</td>
Expand Down
18 changes: 9 additions & 9 deletions migtests/tests/pg/assessment-report-test/expectedAssessmentReport.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,9 +661,9 @@
{
"Category": "unsupported_features",
"CategoryDescription": "Features of the source database that are not supported on the target YugabyteDB.",
"Type": "PK_UK_ON_COMPLEX_DATATYPE",
"Name": "Primary/Unique key on column with complex datatype",
"Description": "Primary key and Unique constraints on columns with complex data types like 'varbit' are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Type": "PK_UK_ON_VARBIT_DATATYPE",
"Name": "Primary/Unique key on column with varbit datatype",
"Description": "Primary key and Unique constraints on columns with varbit data type are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Impact": "LEVEL_1",
"ObjectType": "TABLE",
"ObjectName": "public.combined_tbl, constraint: (combined_tbl_bittv_key)",
Expand All @@ -674,9 +674,9 @@
{
"Category": "unsupported_features",
"CategoryDescription": "Features of the source database that are not supported on the target YugabyteDB.",
"Type": "PK_UK_ON_COMPLEX_DATATYPE",
"Name": "Primary/Unique key on column with complex datatype",
"Description": "Primary key and Unique constraints on columns with complex data types like 'array' are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Type": "PK_UK_ON_ARRAY_DATATYPE",
"Name": "Primary/Unique key on column with array datatype",
"Description": "Primary key and Unique constraints on columns with array data type are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Impact": "LEVEL_1",
"ObjectType": "TABLE",
"ObjectName": "public.combined_tbl, constraint: (combined_tbl_pkey)",
Expand All @@ -687,9 +687,9 @@
{
"Category": "unsupported_features",
"CategoryDescription": "Features of the source database that are not supported on the target YugabyteDB.",
"Type": "PK_UK_ON_COMPLEX_DATATYPE",
"Name": "Primary/Unique key on column with complex datatype",
"Description": "Primary key and Unique constraints on columns with complex data types like 'pg_lsn' are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Type": "PK_UK_ON_PG_LSN_DATATYPE",
"Name": "Primary/Unique key on column with pg_lsn datatype",
"Description": "Primary key and Unique constraints on columns with pg_lsn data type are not yet supported in YugabyteDB. Refer to the docs link for the workaround",
"Impact": "LEVEL_1",
"ObjectType": "TABLE",
"ObjectName": "public.combined_tbl, constraint: (uk)",
Expand Down
Loading