Move ALTER TYPE TEXT DDL to CREATE for metadata tables of target db #2383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyanshi-yb
changed the title
makalaaneesh
reviewed
Mar 6, 2025
| @@ -81,7 +82,7 @@ func (ybc *YugabyteDBCDCClient) GenerateAndStoreStreamID() (string, error) { | |||
| args := fmt.Sprintf("-create -master_addresses %s -table_name %s -db_name %s ", ybc.ybMasterNodes, ybc.tableName, ybc.dbName) | |||
|
|
|||
| if ybc.sslRootCert != "" { | |||
| args += fmt.Sprintf(" -ssl_cert_file %s", ybc.sslRootCert) | |||
| args += fmt.Sprintf(" -ssl_cert_file '%s'", ybc.sslRootCert) | |||
There was a problem hiding this comment.
what is the context for this change?
There was a problem hiding this comment.
I hit this problem when I was trying out with the root cert: If the root cert file name has special characters or spaces, this command will error out if quotes are not present around the file path.
ex. root-cert /<path>/root (2).crt
This might not be really possible in real scenario, but I thought its better to fix it.
makalaaneesh
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in this pull request
ssl-root-certparameter were added to the commands for running the yb-client-wrapper jar.Describe if there are any user-facing changes
No
How was this pull request tested?
Automation tests
Does your PR have changes that can cause upgrade issues?