Update remote of local only #22
Conversation
|
@jayvdb I have updated the project master to include our standard set of linters and formatters. Could you rebase this PR on top of the new master? |
jayvdb
force-pushed
the
remote-local
branch
2 times, most recently
from
2af6508
to
da24870
Compare
|
|
||
| def remote() -> Dict[str, List]: | ||
|
|
||
| def remote(packages: List[PackageVersion] = []) -> Dict[str, List]: |
There was a problem hiding this comment.
Update to remove mutable default args (see https://docs.python-guide.org/writing/gotchas/#mutable-default-arguments):
| def remote(packages: List[PackageVersion] = []) -> Dict[str, List]: | |
| def remote(packages: List[PackageVersion] = None) -> Dict[str, List]: |
There was a problem hiding this comment.
I had that originally; it causes lots of mypy problems, which requires adding noqa or worse voodoo to suppress. Happy to do it if you still want it..
There was a problem hiding this comment.
If you could, yes. In situations like this I always defer to "what would I think if this code was projected in size 128px font a conference" - and in this case I'd be more embarrassed about the mutable args than I would about # type: ignore.
Revisiting this after many years (we don't use it any more), this whole module needs a rethink - remote should just take a list of PackageVersions, it shouldn't be optional at all. If you could fix the args issue I'll merge this and release a version. I can rework the implementation at some point in the future.
There was a problem hiding this comment.
fwiw, no need to rush out a new version. I have other pending PRs to create, and they should be fine to squeeze into the current release.
jayvdb
force-pushed
the
remote-local
branch
from
da24870
to
d22e659
Compare
If --local and --remote used, do not refresh PyPI remote data for any stale records which were not found in local data.
jayvdb
force-pushed
the
remote-local
branch
from
d22e659
to
d51380b
Compare
In effect, this allows enabling local and remote and not clearing, and the update wont try remote sync all of the packages which are stale (not in local)