Skip to content

Commit

Permalink
Remove always failing linter
Browse files Browse the repository at this point in the history
This was introduced in jupyterhub#106,
and has never passed. I don't think we should have a test that is always
expected to fail.

If it should be re-introduced, it should be done in such a way that
whatever changes are needed to make it pass should be part of the PR.

This only reverts the linter, but keeps the rendering test - as that would
help us catch possible jsonnet syntax issues.
  • Loading branch information
yuvipanda committed Jul 19, 2024
1 parent a94bb44 commit dc43320
Showing 1 changed file with 1 addition and 38 deletions.
39 changes: 1 addition & 38 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ on:
workflow_dispatch:

jobs:
render-lint-dashboards:
render-dashboards:
runs-on: ubuntu-22.04

strategy:
Expand All @@ -48,40 +48,3 @@ jobs:
do
jsonnet -J vendor --output-file rendered-dashboards/`basename $file` $file
done
- name: Install dashboard-linter
run: |
go install github.com/grafana/dashboard-linter@latest
echo "$HOME/go/bin" >> "$GITHUB_PATH"
- name: dashboard-linter rules
run: |
echo "Available rules are documented in https://github.com/grafana/dashboard-linter/blob/main/docs/index.md#rules"
echo ""
dashboard-linter rules
- name: dashboard-linter lint
run: |
lint_failures=""
dashboard_folders=rendered-dashboards
for file in `find $dashboard_folders -name '*.jsonnet'`
do
lint_fail=""
echo "::group::$file"
dashboard-linter lint --strict $file || lint_fail=1
echo "::endgroup::"
if [ -n "$lint_fail" ]; then
lint_failures="$lint_failures $file";
fi
done
if [ -n "$lint_failures" ]; then
echo ""
echo "dashboard-linter errored for:"
for file in $lint_failures
do
echo `basename $file`
done
exit 1
fi

0 comments on commit dc43320

Please sign in to comment.