ssh and pssh prefer primary_tag as hostname #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssh and pssh commands were using the first element of search results but it doesn't work well when `tags` option is set at ~/.hotdog/config.yml and the first element is not a hostname. This change prefers to use primary_key instead of the first element if primary_key is set and primary_key is included in the tags option. If tags option is not set or display_search_tags option is set, behavior doesn't change because primary_key exists as the first element.
|
I think, this kind of tag handling is better to be implemented within "get_hosts()" instead of individual commands impl 🤔 https://github.com/yyuu/hotdog/blob/v1.20190725.0/lib/hotdog/commands.rb#L104-L108 |
|
yes. please use this PR in anyways as you would like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ssh and pssh commands were using the first element of search results but
it doesn't work well when
tagsoption is set at ~/.hotdog/config.ymland the first element is not a hostname.
This change prefers to use primary_key instead of the first element if
primary_key is set and primary_key is included in the tags option.
If tags option is not set or display_search_tags option is set, behavior
doesn't change because primary_key exists as the first element.