-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏗 Split CompletionItemProvider into smaller modules #905
base: master
Are you sure you want to change the base?
Commits on Feb 19, 2021
-
New imagePathCompletion function
Code is just moved from the the main completion function. No functional changes Function is async and has a Cancellation token, though the later could likely be better made use of. I've duplicated the lineTextBefore variable within the function rather than passing it in. This is less efficient just now but I think it will be cleaner once all completion functions are separated out. Eventually I don't think it will be needed within the function at all.
Configuration menu - View commit details
-
Copy full SHA for 1062d75 - Browse repository at this point
Copy the full SHA 1062d75View commit details -
New referenceLinkLabelCompletion functions
code is just moved from main completion function. No functional changes.
Configuration menu - View commit details
-
Copy full SHA for f0b03cf - Browse repository at this point
Copy the full SHA f0b03cfView commit details -
New anchorFromHeadingCompletion function
Just moved code from main completion function. No functional changes. lineAfterTest variable also moved in to this function as it is the only place it is used.
Configuration menu - View commit details
-
Copy full SHA for f5f7c9d - Browse repository at this point
Copy the full SHA f5f7c9dView commit details -
New filePathsCompletion function
Code just moved from main function No functional changes.
Configuration menu - View commit details
-
Copy full SHA for df45756 - Browse repository at this point
Copy the full SHA df45756View commit details -
No functional changes, just tidying code.
Configuration menu - View commit details
-
Copy full SHA for 2544a23 - Browse repository at this point
Copy the full SHA 2544a23View commit details -
required renaming of previous `mathCompletion` variable to `mathCompletionItems` Just moving code from main to new function. No functional change. Consider moving `mathCompletionItems` into new function in future
Configuration menu - View commit details
-
Copy full SHA for 214d6bb - Browse repository at this point
Copy the full SHA 214d6bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8816c1d - Browse repository at this point
Copy the full SHA 8816c1dView commit details
Commits on Feb 21, 2021
-
Configuration menu - View commit details
-
Copy full SHA for c21becd - Browse repository at this point
Copy the full SHA c21becdView commit details
Commits on Feb 23, 2021
-
Better defining matches variable
Matches is type string array, The line `matches = lineTextBefore.match(/\\+$/);` seems to be old code and is not doing anything of use. It is repeated a few lines further down in the if statement for maths completion.
Configuration menu - View commit details
-
Copy full SHA for f66c5dc - Browse repository at this point
Copy the full SHA f66c5dcView commit details
Commits on Feb 24, 2021
-
Separating Regex to matchRegex variable
Using named key-value pair for code clarity.
Configuration menu - View commit details
-
Copy full SHA for a82524e - Browse repository at this point
Copy the full SHA a82524eView commit details -
Better latex regex for completion
Previous capture relied on counting number of backslashes after matching a regex and performing modular arithmetic to check for an odd number. This commit is to change the latexCmd regex to a single line which says: `/(^|[^\\])([\\]{2})*\\$/` ``` IF ( ( (on new line) OR (following a non-backslash char) ) AND (0 or more pairs of backslashes) AND a single backslash ) THEN there are an odd number of backslashes. ``` The benefit of this is to better align with the other regex's used in the if-else statement. also removes need for `matches` variable.
Configuration menu - View commit details
-
Copy full SHA for 43ab0ea - Browse repository at this point
Copy the full SHA 43ab0eaView commit details