Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax ruamel.yaml Version Constraint from ~=0.18.7 to >=0.17,<0.19 #204

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

syou6162
Copy link
Contributor

@syou6162 syou6162 commented Jan 23, 2025

Issues

I've been using https://github.com/datacontract/datacontract-cli recently with dbt-osmosis. datacontract-cli uses https://github.com/sodadata/soda-core internally, but soda-core requires ruamel.yaml>=0.17.0,<0.18.0.

On the other hand, dbt-osmosis now requires ruamel.yaml~=0.18.7 due to the change to v1.

At present, I am continuing to use dbt-osmosis v0.14.0 because I use both datacontract-cli and dbt-osmosis, and I have not yet been able to upgrade to dbt-osmosis v1.

Solution

The fundamental solution is to upgrade the version of ruamel.yaml used by soda-core. However, I sent a pull request to soda-core for the first time today, so it is unclear whether the ruamel.yaml fix will be incorporated immediately. It is also expected to take some time for the fix to be incorporated into datacontract-cli, which uses soda-core.

I've seen that many issues have been raised since dbt-osmosis became v1, and I know people who are having trouble with changes in behavior that haven't been raised as issues. In order to resolve these issues, I myself would like to use dbt-osmosis to the fullest with the v1 series, but due to the version conflict with ruamel.yaml mentioned above, this is becoming difficult.

To solve this issue, this pull request relaxes the restrictions on ruamel.yaml. ruamel.yaml==0.18.0 was released over a year ago, so I think the need for support is fading. I am aware that this pull request is not a good fix when considering the future maintenance of dbt-osmosis, but I would be happy if you could consider incorporating this fix so that I can actively contribute to dbt-osmosis as one of its contributors 🙏🙏🙏 .

@z3z1ma
Copy link
Owner

z3z1ma commented Jan 24, 2025

LMK whenever this is rdy for review :)

@syou6162 syou6162 force-pushed the relax-ruamel-yaml-version-constraint branch from 5ccb954 to db0a6d6 Compare January 28, 2025 07:00
@syou6162 syou6162 marked this pull request as ready for review January 28, 2025 07:24
@syou6162
Copy link
Contributor Author

@z3z1ma I've written the background to the fix in the description of the pull request, so could you please review it?

I think this pull request is not a very good fix, but if it can be resolved, I will be able to use dbt-osmosis v1 series to the fullest, so I think I will be able to make a better contribution.

@z3z1ma
Copy link
Owner

z3z1ma commented Jan 29, 2025

Sounds good to me, look forward to your usage and feedback 🙇

@z3z1ma z3z1ma merged commit 40cbe03 into z3z1ma:main Jan 29, 2025
7 checks passed
@syou6162 syou6162 deleted the relax-ruamel-yaml-version-constraint branch January 29, 2025 06:00
@syou6162
Copy link
Contributor Author

@z3z1ma Thank you for merging! I'm looking forward to the new version being released so that the Relax ruamel.yaml Version Constraint is reflected!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants