Relax ruamel.yaml Version Constraint from ~=0.18.7 to >=0.17,<0.19 #204
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
I've been using https://github.com/datacontract/datacontract-cli recently with dbt-osmosis. datacontract-cli uses https://github.com/sodadata/soda-core internally, but soda-core requires
ruamel.yaml>=0.17.0,<0.18.0
.On the other hand, dbt-osmosis now requires
ruamel.yaml~=0.18.7
due to the change to v1.At present, I am continuing to use dbt-osmosis v0.14.0 because I use both datacontract-cli and dbt-osmosis, and I have not yet been able to upgrade to dbt-osmosis v1.
Solution
The fundamental solution is to upgrade the version of
ruamel.yaml
used by soda-core. However, I sent a pull request to soda-core for the first time today, so it is unclear whether theruamel.yaml
fix will be incorporated immediately. It is also expected to take some time for the fix to be incorporated into datacontract-cli, which uses soda-core.I've seen that many issues have been raised since dbt-osmosis became v1, and I know people who are having trouble with changes in behavior that haven't been raised as issues. In order to resolve these issues, I myself would like to use dbt-osmosis to the fullest with the v1 series, but due to the version conflict with
ruamel.yaml
mentioned above, this is becoming difficult.To solve this issue, this pull request relaxes the restrictions on
ruamel.yaml
.ruamel.yaml==0.18.0
was released over a year ago, so I think the need for support is fading. I am aware that this pull request is not a good fix when considering the future maintenance of dbt-osmosis, but I would be happy if you could consider incorporating this fix so that I can actively contribute to dbt-osmosis as one of its contributors 🙏🙏🙏 .