This repository has been archived by the owner on Sep 24, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create CODE_OF_CONDUCT.md
Format and fix some of README.MD
Updated the README
Fwiw, look at #51 first. That should help getting the development branch up to speed with master. Should remove most of the commits you now see in the list. I thought it wouldn't be useful to commit changes to a dev branch that's not up to date with master. |
This is interesting, however the |
Sorry for abandoning this. I don't really know what this was about exactly and I suspect my ideas might be out of date, so I'm closing this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Not sure how to run the unit tests. Saw something in another branch but if I need to run those it makes it really hard to make changes. You'd need to merge the testing branch, run the tests, revert the changes from the testing branch, change code, etc. etc... What do you propose?
Description
I've implemented an abstraction layer for key,value-pairs. This should help with managing subscribers as well as with storing other key,value pairs in json files. With these changes, it should solve #39 by creating the files when a new data point is added. This rests on the assumption that we don't need the files if nothing is written to it. If we need the file beforehand, we'll need to change the logic for this.
The abstraction layer should also help when moving to a database as described in #15. You should only need to change the abstraction layer instead of all the code above.
Let me know if you see any obvious problems. I've tested the datamanager extensively, but didn't test how it works together with the rest of the code. (in production)