vpa: Update to VPA v1.1.1 #111

Signed-off-by: Vishal Anarse <[email protected]>

(cherry picked from commit b9f636d) Signed-off-by: qianlei.qianl <[email protected]> refactor: move logic to create client to utils/kubernetes pkg - expose `CreateKubeClient` as public function - make `GetKubeConfig` into a private `getKubeConfig` function (can be exposed as a public function in the future if needed) Signed-off-by: vadasambar <[email protected]> fix: CI failing because cloudproviders were not updated to use new autoscaling option fields Signed-off-by: vadasambar <[email protected]> refactor: define errors as constants Signed-off-by: vadasambar <[email protected]> refactor: pass kube client options by value Signed-off-by: vadasambar <[email protected]>

…emplate Implement TemplateNodeInfo for civo cloudprovider

Signed-off-by: Vishal Anarse <[email protected]>

refactor(*): move getKubeClient to utils/kubernetes

fix: alicloud the function NodeGroupForNode return nil

…de-template [civo] Calculate real value for template using node group

Remove *_test.go, models/, examples

+ Update version in README + command

…ache-instance-requirements AWS: cache instance requirements

Fix capacityType label in AWS ManagedNodeGroup

…deprecate Azure: Remove AKS vmType

Update cloudprovider/aws/aws-sdk-go to 1.48.7

Fixes scale down logic.

Update AWS instance list - Dec 2023

Helm: update cluster-autoscaler to 1.28

…age-build Switch to multistage build Dockerfiles for VPA

…d-node-group-count flags Signed-off-by: Prashant Rewar <[email protected]>

Error messages were incorrect regardless of which annotation was failing. Also exposing the underlying parse error so it can actually be fixed.

The Hetzner Cloud API returns "Actions" for anything asynchronous that happens inside the backend. When creating a new server multiple actions are returned: `create_server`, `start_server`, `attach_to_network` (if set). Our current code waits for the `create_server` and if it fails, it makes sure to delete the server so cluster-autoscaler can create a new one immediately to provide the required capacity. If one of the "follow up" actions fails though, we do not handle this. This causes issues when the server for whatever reason did not start properly on the first try, as then the customer has a shutdown server, is paying for it, but does not receive the additional capacity for their Kubernetes cluster. This commit fixes the bug, by awaiting all actions returned by the create server API call, and deleting the server if any of them fail.

…actions fix(hetzner): insufficient nodes when boot fails

…aler-annotation-ignore fix: update node annotation used to limit log spam with valid key

feat: add metrics to show target size of every node group

…iles

fix: updated readme for hetzner cloud provider

Change-Id: I3b5c62ba13c2e048ce2d7170016af07182c11eee

Add error details to autoscaling backoff.

Change-Id: I1f812d4d6f42db97670ef7304fc0e895c837a13b

Make backoff.Status.ErrorInfo non-pointer.

…d-flag Deprecate unused node-autoprovisioning-enabled and max-autoprovisioned-node-group-count flags

Signed-off-by: lizhen <[email protected]>

[GCE] Support paginated instance listing

allow specifing grpc timeout rather than hardcoded 5 seconds

Signed-off-by: Jack Francis <[email protected]>

Remove vpa builder Dockerfile and switch dependabot to component Dockerfiles

…ks-deprecate azure: fix chart bugs after AKS vmType deprecation

Add VSCode workspace files to .gitignore

…ons are given

Signed-off-by: Vishal Anarase <[email protected]>

Implement priority based evictor

Update VPA release README to reference 1.X VPA versions.

[cluster-autoscaler] chore: Rename Cluster Autoscaler Provider package from Packet to EquinixMetal

…mple Fix:Adding missing RBAC + Update Deployment tolerations

[civo] Add Gpu count to node template

Update dependabot.yml to include addon-resizer

…o for backoff and more node counts. Change-Id: Ic68e0d67b7ce9912b605b6c0a3356b4d0e177911

…roup. Max size of configmap is 1MB. Change-Id: I615d25781e4f8dafb6a08f752c085544bcd49e5a

* Regenerate patch release schedule Schedule based on https://kubernetes.io/releases/patch-releases/#upcoming-monthly-releases. Included more rows to have one entry per maintainer. * Update README.md Added concrete dates for future patch releases. * Update README.md Include minor releases in the release schedule.

Partially undo kubernetes#6274. I noticed that with this change CA get rate limited and slows down significantly (especially during large scale downs).

…miting Restore flags for setting QPS limit in CA

Convert status in cluster-autoscaler-status to yaml and add error info for scale-up backoff

Change-Id: Ie6a2301f4ab8673b9ad2f8f7de1faa166ac295b4

Fix typo

Pass Burst and QPS client params to clusterapi k8s clients

…derid Azure: skip non azure nodes

* Introduce ProvisioningRequestPodsFilter processor * Review

This commit clarifies the condition when a node can be scaled down by the Cluster Autoscaler (CA). The changes updates the section and flag description in the FAQ.md and main.go files.

Clarify Scale down rule in the documentation (FAQ.md)

Refactors status_test.go to use table tests

Fixed the TOC of Multi-dimensional Pod Autoscaler AEP.

Bumps golang from 1.21.5 to 1.21.6. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

…vertical-pod-autoscaler/pkg/admission-controller/golang-1.21.6 Bump golang from 1.21.5 to 1.21.6 in /vertical-pod-autoscaler/pkg/admission-controller

…vertical-pod-autoscaler/pkg/recommender/golang-1.21.6 Bump golang from 1.21.5 to 1.21.6 in /vertical-pod-autoscaler/pkg/recommender

…vertical-pod-autoscaler/pkg/updater/golang-1.21.6 Bump golang from 1.21.5 to 1.21.6 in /vertical-pod-autoscaler/pkg/updater

Signed-off-by: vadasambar <[email protected]> feat: update scale down status after every scale up - move scaledown delay status to cluster state/registry - enable scale down if `ScaleDownDelayTypeLocal` is enabled - add new funcs on cluster state to get and update scale down delay status - use timestamp instead of booleans to track scale down delay status Signed-off-by: vadasambar <[email protected]> refactor: use existing fields on clusterstate - uses `scaleUpRequests`, `scaleDownRequests` and `scaleUpFailures` instead of `ScaleUpDelayStatus` - changed the above existing fields a little to make them more convenient for use - moved initializing scale down delay processor to static autoscaler (because clusterstate is not available in main.go) Signed-off-by: vadasambar <[email protected]> refactor: remove note saying only `scale-down-after-add` is supported - because we are supporting all the flags Signed-off-by: vadasambar <[email protected]> fix: evaluate `scaleDownInCooldown` the old way only if `ScaleDownDelayTypeLocal` is set to `false` Signed-off-by: vadasambar <[email protected]> refactor: remove line saying `--scale-down-delay-type-local` is only supported for `--scale-down-delay-after-add` - because it is not true anymore - we are supporting all `--scale-down-delay-after-*` flags per nodegroup Signed-off-by: vadasambar <[email protected]> test: fix clusterstate tests failing Signed-off-by: vadasambar <[email protected]> refactor: move back initializing processors logic to from static autoscaler to main - we don't want to initialize processors in static autoscaler because anyone implementing an alternative to static_autoscaler has to initialize the processors - and initializing specific processors is making static autoscaler aware of an implementation detail which might not be the best practice Signed-off-by: vadasambar <[email protected]> refactor: revert changes related to `clusterstate` - since I am going with observer pattern Signed-off-by: vadasambar <[email protected]> feat: add observer interface for state of scaling - to implement observer pattern for tracking state of scale up/downs (as opposed to using clusterstate to do the same) - refactor `ScaleDownCandidatesDelayProcessor` to use fields from the new observer Signed-off-by: vadasambar <[email protected]> refactor: remove params passed to `clearScaleUpFailures` - not needed anymore Signed-off-by: vadasambar <[email protected]> refactor: revert clusterstate tests - approach has changed - I am not making any changes in clusterstate now Signed-off-by: vadasambar <[email protected]> refactor: add accidentally deleted lines for clusterstate test Signed-off-by: vadasambar <[email protected]> feat: implement `Add` fn for scale state observer - to easily add new observers - re-word comments - remove redundant params from `NewDefaultScaleDownCandidatesProcessor` Signed-off-by: vadasambar <[email protected]> fix: CI complaining because no comments on fn definitions Signed-off-by: vadasambar <[email protected]> feat: initialize parent `ScaleDownCandidatesProcessor` - instead of `ScaleDownCandidatesSortingProcessor` and `ScaleDownCandidatesDelayProcessor` separately Signed-off-by: vadasambar <[email protected]> refactor: add scale state notifier to list of default processors - initialize processors for `NewDefaultScaleDownCandidatesProcessor` outside and pass them to the fn - this allows more flexibility Signed-off-by: vadasambar <[email protected]> refactor: add observer interface - create a separate observer directory - implement `RegisterScaleUp` function in the clusterstate - TODO: resolve syntax errors Signed-off-by: vadasambar <[email protected]> feat: use `scaleStateNotifier` in place of `clusterstate` - delete leftover `scale_stateA_observer.go` (new one is already present in `observers` directory) - register `clustertstate` with `scaleStateNotifier` - use `Register` instead of `Add` function in `scaleStateNotifier` - fix `go build` - wip: fixing tests Signed-off-by: vadasambar <[email protected]> test: fix syntax errors - add utils package `pointers` for converting `time` to pointer (without having to initialize a new variable) Signed-off-by: vadasambar <[email protected]> feat: wip track scale down failures along with scale up failures - I was tracking scale up failures but not scale down failures - fix copyright year 2017 -> 2023 for the new `pointers` package Signed-off-by: vadasambar <[email protected]> feat: register failed scale down with scale state notifier - wip writing tests for `scale_down_candidates_delay_processor` - fix CI lint errors - remove test file for `scale_down_candidates_processor` (there is not much to test as of now) Signed-off-by: vadasambar <[email protected]> test: wip tests for `ScaleDownCandidatesDelayProcessor` Signed-off-by: vadasambar <[email protected]> test: add unit tests for `ScaleDownCandidatesDelayProcessor` Signed-off-by: vadasambar <[email protected]> refactor: don't track scale up failures in `ScaleDownCandidatesDelayProcessor` - not needed Signed-off-by: vadasambar <[email protected]> test: better doc comments for `TestGetScaleDownCandidates` Signed-off-by: vadasambar <[email protected]> refactor: don't ignore error in `NGChangeObserver` - return it instead and let the caller decide what to do with it Signed-off-by: vadasambar <[email protected]> refactor: change pointers to values in `NGChangeObserver` interface - easier to work with - remove `expectedAddTime` param from `RegisterScaleUp` (not needed for now) - add tests for clusterstate's `RegisterScaleUp` Signed-off-by: vadasambar <[email protected]> refactor: conditions in `GetScaleDownCandidates` - set scale down in cool down if the number of scale down candidates is 0 Signed-off-by: vadasambar <[email protected]> test: use `ng1` instead of `ng2` in existing test Signed-off-by: vadasambar <[email protected]> feat: wip static autoscaler tests Signed-off-by: vadasambar <[email protected]> refactor: assign directly instead of using `sdProcessor` variable - variable is not needed Signed-off-by: vadasambar <[email protected]> test: first working test for static autoscaler Signed-off-by: vadasambar <[email protected]> test: continue working on static autoscaler tests Signed-off-by: vadasambar <[email protected]> test: wip second static autoscaler test Signed-off-by: vadasambar <[email protected]> refactor: remove `Println` used for debugging Signed-off-by: vadasambar <[email protected]> test: add static_autoscaler tests for scale down delay per nodegroup flags Signed-off-by: vadasambar <[email protected]> chore: rebase off the latest `master` - change scale state observer interface's `RegisterFailedScaleup` to reflect latest changes around clusterstate's `RegisterFailedScaleup` in `master` Signed-off-by: vadasambar <[email protected]> test: fix clusterstate test failing Signed-off-by: vadasambar <[email protected]> test: fix failing orchestrator test Signed-off-by: vadasambar <[email protected]> refactor: rename `defaultScaleDownCandidatesProcessor` -> `combinedScaleDownCandidatesProcessor` - describes the processor better Signed-off-by: vadasambar <[email protected]> refactor: replace `NGChangeObserver` -> `NodeGroupChangeObserver` - makes it easier to understand for someone not familiar with the codebase Signed-off-by: vadasambar <[email protected]> docs: reword code comment `after` -> `for which` Signed-off-by: vadasambar <[email protected]> refactor: don't return error from `RegisterScaleDown` - not needed as of now (no implementer function returns a non-nil error for this function) Signed-off-by: vadasambar <[email protected]> refactor: address review comments around ng change observer interface - change dir structure of nodegroup change observer package - stop returning errors wherever it is not needed in the nodegroup change observer interface - rename `NGChangeObserver` -> `NodeGroupChangeObserver` interface (makes it easier to understand) Signed-off-by: vadasambar <[email protected]> refactor: make nodegroupchange observer thread-safe Signed-off-by: vadasambar <[email protected]> docs: add TODO to consider using multiple mutexes in nodegroupchange observer Signed-off-by: vadasambar <[email protected]> refactor: use `time.Now()` directly instead of assigning a variable to it Signed-off-by: vadasambar <[email protected]> refactor: share code for checking if there was a recent scale-up/down/failure Signed-off-by: vadasambar <[email protected]> test: convert `ScaleDownCandidatesDelayProcessor` into table tests Signed-off-by: vadasambar <[email protected]> refactor: change scale state notifier's `Register()` -> `RegisterForNotifications()` - makes it easier to understand what the function does Signed-off-by: vadasambar <[email protected]> test: replace scale state notifier `Register` -> `RegisterForNotifications` in test - to fix syntax errors since it is already renamed in the actual code Signed-off-by: vadasambar <[email protected]> refactor: remove `clusterStateRegistry` from `delete_in_batch` tests - not needed anymore since we have `scaleStateNotifier` Signed-off-by: vadasambar <[email protected]> refactor: address PR review comments Signed-off-by: vadasambar <[email protected]> fix: add empty `RegisterFailedScaleDown` for clusterstate - fix syntax error in static autoscaler test Signed-off-by: vadasambar <[email protected]>

Taint utils taking multiple taints

…wn-after-add-per-ng-poc feat: support `--scale-down-delay-after-*` per nodegroup

Rancher: Fix error messages and expose underlying error.

Existing bucketing is inconsistent. Specifically, the second to last bucket is [100, 1000), which is huge and doesn't allow to differentiate between something that took 2m (120s) and something that took 15m (900s).

Use exponential buckets for function_duration_seconds

fix(kwok): prevent quitting when scaling down node group

Fix VPA e2e test failures

…om/guopeng0/autoscaler into feature/node_group_healthy_metrics

…n_ds_v2 Allow draining when DaemonSet kind has custom API Group

…ealthy_metrics feat:add node group health and back off metrics

…Deployment

…cId.

Introduce GceInstance that extends cloudprovider.Instance with NumericId

* ScaleUp for check-capacity ProvisioningRequestClass * update condition logic * Update tests * Naming update * Update cluster-autoscaler/core/scaleup/orchestrator/wrapper_orchestrator_test.go Co-authored-by: Bartek Wróblewski <[email protected]> --------- Co-authored-by: Bartek Wróblewski <[email protected]>

Signed-off-by: vadasambar <[email protected]>

…r-panic

Consider atomic nodes

This change adds the informer factory as an argument to the `buildCloudProvider` function for clusterapi so that building with tags will work properly.

…-owner-ref [VPA] check OwnerRef against TargetRef to confirm VPA/Pod association

…c-improvement doc: cluster-autoscaler: Oracle provider: Add small security note

Update the VPA Version to v1.0.0

Bump CA Chart image to v1.29

…ar-to-reviewers chore: add vadasambar to cluster-autoscaler reviewers

…s_equinixmetal Added the RBAC Permission to equinixmetal Cloud Provider.

…r-panic

…enaming Update Auto Labels of Subprojects

chore: remove unused arg from StaticAutoScaler

…mCloudProvider-panic fix: panic in deleteNodesFromCloudProvider

Stop (un)tainting nodes from unselected node groups.

Also, introduce default per-node logging quotas. For now, identical to the per-pod ones.

Allow overriding timeouts in GCE cloud provider

Bumps golang from 1.21.6 to 1.22.0. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

The version of golang.org/x/net currently used is vulnerable to https://avd.aquasec.com/nvd/2023/cve-2023-39325/, bump it to fix that.

…lder-from-ctx-to-orchestrator-init Move estimatorBuilder from AutoscalingContext to Orchestrator Init

Bump go version.

…vertical-pod-autoscaler/pkg/recommender/golang-1.22.0 Bump golang from 1.21.6 to 1.22.0 in /vertical-pod-autoscaler/pkg/recommender

…vertical-pod-autoscaler/pkg/admission-controller/golang-1.22.0 Bump golang from 1.21.6 to 1.22.0 in /vertical-pod-autoscaler/pkg/admission-controller

VPA: bump golang.org/x/net to fix CVE-2023-39325

Reduce log spam in AtomicResizeFilteringProcessor

…ources add option to keep node group backoff on OutOfResource error

Fix e2e test setup

…vertical-pod-autoscaler/pkg/updater/golang-1.22.0 Bump golang from 1.21.6 to 1.22.0 in /vertical-pod-autoscaler/pkg/updater

GCE: Implement kube-env caching

…ovider Introduce LocalSSDSizeProvider interface for GCE

…ter-fix Fix expectedToRegister to respect instances with nil status

extract create group to a function

Refactor references to taints & tolerations, replacing master key with control-plane across all the example YAMLs. Signed-off-by: Feruzjon Muyassarov <[email protected]>

…-down

Signed-off-by: Feruzjon Muyassarov <[email protected]>

CA FAQ: clarify the point about scheduling constraints blocking scale-down

* Add ProvisioningRequests injector * Add test case for Accepted conditions and add supported provreq classes list * Use Passive clock

…mic scale-downs

Consider preemption policy for expandable pods

…l-storage [Hetzner] Fix missing ephemeral storage definition

CA: GCE: add pricing for new Z3 machines

docs: update outdated/deprecated taints in the examples

…-cleanup Add warning about vendor removal to Makefile build target

Fix a bug where atomic scale-down failure could affect subsequent atomic scale-downs

Migrate from satori/go.uuid to gofrs/uuid

…rns 404

Add BuildTestNodeWithAllocatable test utility method.

…r-builder add informer argument to clusterapi provider builder

…builder Add informer argument to the CloudProviders builder.

CA: update master dependencies to k8s v1.30.0-alpha.3, go1.21.8

Delay force refresh by DefaultInterval when OCI GetNodePool call retu…

Bumps golang from 1.22.0 to 1.22.1. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Update expander options for the AWS cloud provider README

…vertical-pod-autoscaler/pkg/recommender/golang-1.22.1 Bump golang from 1.22.0 to 1.22.1 in /vertical-pod-autoscaler/pkg/recommender

…vertical-pod-autoscaler/pkg/admission-controller/golang-1.22.1 Bump golang from 1.22.0 to 1.22.1 in /vertical-pod-autoscaler/pkg/admission-controller

…vertical-pod-autoscaler/pkg/updater/golang-1.22.1 Bump golang from 1.22.0 to 1.22.1 in /vertical-pod-autoscaler/pkg/updater

…-1.29-update-compatibility-matrix CA - Add 1.29 to version compatibility matrix

Bump VPA version to 1.1.0

As part of the 1.1.0 release: kubernetes#6388

Bump default VPA version to 1.1.0 in vpa-release-1.1 branch

…pa-updater-npe-to-release-1.1 [vpa-release-1.1] Cherry-pick of kubernetes#6712: Fix NPE in vpa-updater when Pod owner isn't scalable

Bump VPA version to 1.1.1

Bump vpa version to 1.1.1

Vertical Pod Autoscaler release 1.1.1

Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>

Commits on Feb 12, 2024

Fix e2e test setup

voelzmo committed Feb 12, 2024

Configuration menu

View commit details

Copy full SHA for 2de6976

Browse repository at this point

Copy the full SHA

2de6976 View commit details

Browse the repository at this point in the history

Commits on Mar 2, 2024

Update gce_price_info.go

AnishShah authored Mar 2, 2024

Configuration menu

View commit details

Copy full SHA for cc75680

Browse repository at this point

Copy the full SHA

cc75680 View commit details

Browse the repository at this point in the history

vpa: Update to VPA v1.1.1 #111

vpa: Update to VPA v1.1.1 #111

Commits on Nov 28, 2023

Commits on Nov 29, 2023

Commits on Nov 30, 2023

Commits on Dec 4, 2023

Commits on Dec 5, 2023

Commits on Dec 6, 2023

Commits on Dec 8, 2023

Commits on Dec 9, 2023

Commits on Dec 11, 2023

Commits on Dec 12, 2023

Commits on Dec 13, 2023

Commits on Dec 14, 2023

Commits on Dec 15, 2023

Commits on Dec 19, 2023

Commits on Dec 20, 2023

Commits on Dec 21, 2023

Commits on Dec 22, 2023

Commits on Dec 27, 2023

Commits on Dec 28, 2023

Commits on Dec 29, 2023

Commits on Jan 2, 2024

Commits on Jan 3, 2024

Commits on Jan 7, 2024

Commits on Jan 8, 2024

Commits on Jan 10, 2024

Commits on Jan 11, 2024

Commits on Jan 12, 2024

Commits on Jan 13, 2024

Commits on Jan 15, 2024

Commits on Jan 17, 2024

Commits on Jan 18, 2024

Commits on Jan 19, 2024

Commits on Jan 22, 2024

Commits on Jan 23, 2024

Commits on Jan 24, 2024

Commits on Jan 25, 2024

Commits on Jan 29, 2024

Commits on Jan 30, 2024

Commits on Jan 31, 2024

Commits on Feb 1, 2024

Commits on Feb 4, 2024

Commits on Feb 5, 2024

Commits on Feb 6, 2024

Commits on Feb 7, 2024

Commits on Feb 8, 2024

Commits on Feb 9, 2024

Commits on Feb 12, 2024

Commits on Feb 13, 2024

Commits on Feb 14, 2024

Commits on Feb 15, 2024

Commits on Feb 16, 2024

Commits on Feb 20, 2024

Commits on Feb 22, 2024

Commits on Feb 23, 2024

Commits on Feb 26, 2024

Commits on Feb 27, 2024

Commits on Feb 28, 2024

Commits on Mar 2, 2024

Commits on Mar 4, 2024

Commits on Mar 5, 2024

Commits on Mar 6, 2024

Commits on Mar 7, 2024

Commits on Mar 8, 2024

Commits on Mar 11, 2024

Commits on Mar 25, 2024

Commits on Apr 5, 2024

Commits on Apr 17, 2024

Commits on Apr 18, 2024

Commits on Apr 24, 2024

Commits on Apr 25, 2024

Commits on May 6, 2024