add template function #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myaser
force-pushed
the
template-function
branch
from
242e75d
to
4e22ef2
Compare
gargravarr
reviewed
Aug 18, 2023
Signed-off-by: Mahmoud Gaballah <[email protected]>
myaser
force-pushed
the
template-function
branch
from
4e22ef2
to
7930f40
Compare
|
👍 |
1 similar comment
|
👍🏻 |
mikkeloscar
reviewed
Aug 18, 2023
|
|
||
| // nodeLifeCycleProviderPerNodePoolGroup groups node-pools by the dedicated label, each node-pool-group is mapped to | ||
| // the provider suitable for its node-pool profile | ||
| // in case all pools of a group do not share the same profile, the group is mapped to empty string |
There was a problem hiding this comment.
What does this mean in practice? Which provider would be used here by admission-controller? 🤔
There was a problem hiding this comment.
an empty string "" provider will be used, which is practically turning this feature off
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add template function to be used in k8s-on-aws; it is grouping node-pools by the dedicated label, then finding if there is a common profile, it is then return a string value "karpenter", "zalando", or "" based on the profile