Add a cluster method Name to get canonical clusterName based on provider #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
mikkeloscar
added
the
minor
1 task
mikkeloscar
force-pushed
the
clusterName-template-func
branch
2 times, most recently
from
e1fa341
to
ae70ee3
Compare
linki
reviewed
Nov 1, 2024
linki
reviewed
Nov 1, 2024
mikkeloscar
force-pushed
the
clusterName-template-func
branch
from
ae70ee3
to
74d83f6
Compare
Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
mikkeloscar
force-pushed
the
clusterName-template-func
branch
from
74d83f6
to
f675c9b
Compare
|
👍 |
mikkeloscar
changed the title
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a cluster method
Name()which returns the canonical cluster ID/Name based on the cluster Provider.This is helpful as for non-EKS we use the full
IDas cluster ID e.g. via tags on resources and for EKS we use onlyLocalIDas theIDis not compatible with EKS because of:in the value.This makes it simpler to template such that both EKS and non-EKS is supported.