Allow using precise floats in logs #2005
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasmarian
requested review from
whiskeysierra,
lukasniemeier-zalando and
msdousti
as code owners
msdousti
reviewed
Jan 11, 2025
| > Filters for JSON bodies are using Jackson, which comes with a defect of dropping off precision from floating point | ||
| > numbers (see [FasterXML/jackson-core/issues/984](https://github.com/FasterXML/jackson-core/issues/984)). | ||
| > | ||
| > This can be changed by setting the `usePreciseFloats` flag to true in the filter respective filters. |
There was a problem hiding this comment.
Maybe point out herr that using this setting can impose a performance penalty on the application due to encoding floats as BigDecimal.
| @@ -27,7 +38,11 @@ public String compact(final String json) throws IOException { | |||
| final JsonGenerator generator = factory.createGenerator(output)) { | |||
|
|
|||
| while (parser.nextToken() != null) { | |||
| generator.copyCurrentEvent(parser); | |||
| if (usePreciseFloats) { | |||
There was a problem hiding this comment.
Can this logic be refactored?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows using precise floats in logs.
Several JSON body filters in Logbook use
JsonGeneratorto reconstruct the payload.generator.copyCurrentEvent method has a flaw when writing float numbers. This may result in logging a different float value than the actual value that was in the payload.
With this change, I'm adding an optional boolean flag to all JSON body filters to use copyCurrentEventExact instaed. That may come with a performance impact (not sure how significant).
Motivation and Context
#1993
Types of changes
Checklist: