refactor(shortint): refactor the shortint keyswitching code #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this manages better all the cases we encouter, we force a refresh PBS in all cases for now which is less optimal in certain cases but allows to be safe in cases where keyswitches might be chained
|
I'll push a second commit tomorrow that will have an edge case test which this code fixes |
|
Seems to be working now! (based on 1 test). Running a more extensive test suit but it'll take some time. |
Added a test with something more similar to what you do, test passes, so should be fine hoepfully |
tmontaigu
approved these changes
Jul 26, 2024
|
I'll let you guys merge this, I'll likely be off before I can, please include it in the alpha.2 of monday @nsarlin-zama |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: https://github.com/zama-ai/tfhe-rs-internal/issues/670
PR content/description
cc @titouantanguy to check the cases which were failing previously