refactor(gpu): remove max_shared_memory from pbs arguments #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnesLeroy
force-pushed
the
al/clean_max_shared_memory
branch
from
02f0c7f
to
c0cc4a3
Compare
pdroalves
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
A long time waiting PR. Thank you @agnesLeroy !
The only thing that came to my eyes was the replacement of cuda_get_max_shared_memory(gpu_indexes[0]) by cuda_get_max_shared_memory(0). If that is intentional, then we are good to go.
agnesLeroy
force-pushed
the
al/clean_max_shared_memory
branch
from
c0cc4a3
to
df03a52
Compare
agnesLeroy
force-pushed
the
al/clean_max_shared_memory
branch
from
df03a52
to
f1c62bb
Compare
agnesLeroy
force-pushed
the
al/clean_max_shared_memory
branch
from
f1c62bb
to
5858c38
Compare
agnesLeroy
force-pushed
the
al/clean_max_shared_memory
branch
from
5858c38
to
821ce5a
Compare
Always use max shared memory from device 0 to configure the kernels, to avoid bugs with multi-GPU configurations
agnesLeroy
force-pushed
the
al/clean_max_shared_memory
branch
from
821ce5a
to
02521c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always use max shared memory from device 0 to configure the kernels, to avoid bugs with multi-GPU configurations
closes: please link all relevant issues
PR content/description
Check-list: