impl Versionize for HashSet/HashMap and Box<[T]>/ABox<[T]> #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsarlin-zama
force-pushed
the
ns/versionize_hashmap
branch
2 times, most recently
from
6dcd897
to
90c1197
Compare
nsarlin-zama
force-pushed
the
ns/versionize_hashmap
branch
from
90c1197
to
7e51285
Compare
nsarlin-zama
changed the title
|
Thanks @nsarlin-zama ! I checked the hashmap and Abox implementation, they all work on the kms side |
kc1212
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: please link all relevant issues
PR content/description
The implem converts to
Vec<T::Versioned>for HashSet andVec<(K::Versioned, V::Versioned)>for HashMap to remove the bound on Eq/Hash for the versioned type. That shouldn't matter since the versioned type is not supposed to be modified before serialization.This PR also implements Versionize for
Box<[T]>andABox<[T]>(boxed slices)