Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Am/feat/more efficient integer list expansion #1589

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Am/feat/more efficient integer list expansion #1589

merged 3 commits into from
Sep 30, 2024

Conversation

IceTDrinker
Copy link
Member

closes: please link all relevant issues

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@cla-bot cla-bot bot added the cla-signed label Sep 25, 2024
@IceTDrinker IceTDrinker force-pushed the am/feat/more-efficient-integer-list-expansion branch 3 times, most recently from eb6185d to 2a7475d Compare September 26, 2024 07:54
tmontaigu
tmontaigu reviewed Sep 26, 2024
View reviewed changes
tfhe/src/shortint/ciphertext/zk.rs Outdated Show resolved Hide resolved
tfhe/src/integer/ciphertext/compact_list.rs Outdated Show resolved Hide resolved
tfhe/src/integer/ciphertext/compact_list.rs Outdated Show resolved Hide resolved
@IceTDrinker IceTDrinker force-pushed the am/feat/more-efficient-integer-list-expansion branch from 2a7475d to 2b48ad8 Compare September 26, 2024 14:05
@IceTDrinker
Copy link
Member Author

Failure in integer test, this is not critical for the release

@IceTDrinker IceTDrinker force-pushed the am/feat/more-efficient-integer-list-expansion branch from 2b48ad8 to 38cae9c Compare September 26, 2024 19:15
@zama-bot zama-bot removed the approved label Sep 26, 2024
@IceTDrinker
Copy link
Member Author

fixed it, issue was a problem with output degree not being properly updated in a case we were interested in, other cases the degree was already properly handled, added an assert on degrees in the test case that failed, relaunched tests with approved label

@IceTDrinker IceTDrinker changed the base branch from main to release_pr_stack September 30, 2024 18:11
@IceTDrinker IceTDrinker force-pushed the am/feat/more-efficient-integer-list-expansion branch from 38cae9c to b61ed87 Compare September 30, 2024 18:11
@zama-bot zama-bot removed the approved label Sep 30, 2024
Base automatically changed from release_pr_stack to main September 30, 2024 18:15
@IceTDrinker IceTDrinker force-pushed the am/feat/more-efficient-integer-list-expansion branch from b61ed87 to 87c0a08 Compare September 30, 2024 18:17
@zama-bot zama-bot removed the approved label Sep 30, 2024
@IceTDrinker IceTDrinker merged commit dedb3e9 into main Sep 30, 2024
69 of 70 checks passed
@IceTDrinker IceTDrinker deleted the am/feat/more-efficient-integer-list-expansion branch September 30, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmontaigu tmontaigu tmontaigu approved these changes

@mayeul-zama mayeul-zama Awaiting requested review from mayeul-zama

@nsarlin-zama nsarlin-zama Awaiting requested review from nsarlin-zama

Assignees
No one assigned
Labels
approved cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IceTDrinker @tmontaigu @zama-bot